Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1834853003: Allow continuous request dispatch below the throttle rate (Closed)

Created:
4 years, 9 months ago by jdduke (slow)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, scheduler-bugs_chromium.org, darin-cc_chromium.org, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow continuous request dispatch below the throttle rate ResourceDispatchThrottler will throttle requests when a give threshold is reached within a given time window. However, it is overly restrictive when the requests are continuous, as the sliding time window was keyed off the most recently sent request. Fix this by tracking the flush time, rather than the last sent request time, allowing continuous request dispatch at or below the specified throttling rate. BUG=592037 Committed: https://crrev.com/46c01a93646af14072ce25fc59a9b59b29f097d7 Cr-Commit-Position: refs/heads/master@{#383740}

Patch Set 1 #

Patch Set 2 : LogFLush #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -10 lines) Patch
M content/renderer/scheduler/resource_dispatch_throttler.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/scheduler/resource_dispatch_throttler.cc View 1 4 chunks +17 lines, -9 lines 0 comments Download
M content/renderer/scheduler/resource_dispatch_throttler_unittest.cc View 2 chunks +40 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
jdduke (slow)
Hey guys :)
4 years, 9 months ago (2016-03-25 16:57:59 UTC) #3
alex clarke (OOO till 29th)
lgtm Thanks Jarred. Sami tried this patch with the bug repro and it looked like ...
4 years, 8 months ago (2016-03-29 11:32:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834853003/20001
4 years, 8 months ago (2016-03-29 15:22:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 16:33:46 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 16:35:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46c01a93646af14072ce25fc59a9b59b29f097d7
Cr-Commit-Position: refs/heads/master@{#383740}

Powered by Google App Engine
This is Rietveld 408576698