Fix MenuRunnerImpl Crash for context menu during drag-and-drop

Fix MenuRunnerImpl Crash for context menu during drag-and-drop

A user could cause a crash in release builds of chromium by dragging an extension from the toolbar into the app menu. Then while not releasing the dragged item, use arrow keys to select another extension icon. Then pressing right-click-menu key on a keyboard.

This was because MenuRunner was not expecting nesting of MenuControllerDelegates within drag-ang-drop menus.

This was not caught earlier as key handling in MenuController had a DCHECK to prevent key handling during drag-and-drop.

This change addressed the crash in MenuRunnerImpl.
Additionally both MenuController::OnKeyDown and MenuController::SelectByChar will exit instead of handling key events. We don't want a multi-model drag-and-drop / keyboard interaction model.

TEST=MenuRunnerTest.NestingDuringDrag and manual testing
BUG=597669
Committed: https://crrev.com/896fcf08e23a57d82ff9eeb003b7b875ecb17d2b
Cr-Commit-Position: refs/heads/master@{#383717}

[jonross, 2016-03-24 21:25:37]

jonross@chromium.org changed reviewers:
+ sky@chromium.org, varkha@chromium.org

[jonross, 2016-03-24 21:25:38]

Hi Sky,

This change fixes a crash in MenuRunnerImpl. I also remove MenuController key
handling during drag-and-drop, as that should not be supported.

PTAL.

Thanks,
Jon

[sky, 2016-03-25 15:16:55]

LGTM

[jonross, 2016-03-29 13:46:55]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-03-29 13:47:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834823002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834823002/1

[commit-bot: I haz the power, 2016-03-29 14:25:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-29 14:26:30]

Description was changed from

==========
Fix MenuRunnerImpl Crash for context menu during drag-and-drop

A user could cause a crash in release builds of chromium by dragging an
extension from the toolbar into the app menu. Then while not releasing the
dragged item, use arrow keys to select another extension icon. Then pressing
right-click-menu key on a keyboard.

This was because MenuRunner was not expecting nesting of MenuControllerDelegates
within drag-ang-drop menus.

This was not caught earlier as key handling in MenuController had a DCHECK to
prevent key handling during drag-and-drop.

This change addressed the crash in MenuRunnerImpl.
Additionally both MenuController::OnKeyDown and MenuController::SelectByChar
will exit instead of handling key events. We don't want a multi-model
drag-and-drop / keyboard interaction model.

TEST=MenuRunnerTest.NestingDuringDrag and manual testing
BUG=597669
==========

to

==========
Fix MenuRunnerImpl Crash for context menu during drag-and-drop

A user could cause a crash in release builds of chromium by dragging an
extension from the toolbar into the app menu. Then while not releasing the
dragged item, use arrow keys to select another extension icon. Then pressing
right-click-menu key on a keyboard.

This was because MenuRunner was not expecting nesting of MenuControllerDelegates
within drag-ang-drop menus.

This was not caught earlier as key handling in MenuController had a DCHECK to
prevent key handling during drag-and-drop.

This change addressed the crash in MenuRunnerImpl.
Additionally both MenuController::OnKeyDown and MenuController::SelectByChar
will exit instead of handling key events. We don't want a multi-model
drag-and-drop / keyboard interaction model.

TEST=MenuRunnerTest.NestingDuringDrag and manual testing
BUG=597669

Committed: https://crrev.com/896fcf08e23a57d82ff9eeb003b7b875ecb17d2b
Cr-Commit-Position: refs/heads/master@{#383717}
==========

[commit-bot: I haz the power, 2016-03-29 14:26:31]

Patchset 1 (id:??) landed as
https://crrev.com/896fcf08e23a57d82ff9eeb003b7b875ecb17d2b
Cr-Commit-Position: refs/heads/master@{#383717}