Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1834813002: Support -rdynamic option in the new driver (Closed)

Created:
4 years, 9 months ago by Petr Hosek
Modified:
4 years, 9 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/a/native_client/pnacl-clang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support -rdynamic option in the new driver This option does not have any effect for bitcode linking, but it is supported by the existing driver and used by existing software packages hence its use should not trigger an error. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347 R=dschuff@chromium.org Committed: ce163fdd0f16b4481e5cf77a16d45e9b4dc8300e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M lib/Driver/Tools.cpp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Petr Hosek
4 years, 9 months ago (2016-03-24 21:14:40 UTC) #1
Derek Schuff
lgtm
4 years, 9 months ago (2016-03-24 21:26:18 UTC) #2
Petr Hosek
4 years, 9 months ago (2016-03-24 21:27:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce163fdd0f16b4481e5cf77a16d45e9b4dc8300e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698