ProcessSingleton now uses base::win::MessageWindow to create a message-only window.

ProcessSingleton now uses base::win::MessageWindow to create a message-only window.

Collateral changes:
- base::win::MessageWindow registes a single window class used by all message-only windows it creates. The class is registered via base::LazyInstance.
- Added base::win::MessageWindow::FindWindow() wrapper used to find other message-only windows, including the other created by a different process.
- Removed chrome::kMessageWindowClass constant.
- chrome_frame_test::ContextMenuTest destroys the clipboard during the test teardown.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211049

[alexeypa (please no reviews), 2013-07-03 23:07:53]

Relanding r209047 (https://chromiumcodereview.appspot.com/17615003).

Patch #1 is the original CL. Patch #2 is the fix.

erikwright@ - PTAL at src/chrome_frame/* - changes.

cpu@, thestig@ - please rubberstump the rest for relanding.

[cpu_(ooo_6.6-7.5), 2013-07-04 00:04:32]

lgtm

[alexeypa (please no reviews), 2013-07-08 17:08:00]

Just a friendly post 4th of July ping. :-)

[pastarmovj, 2013-07-09 08:03:02]

lgtm as far as the changed order of lock file vs. window  destruction goes. I
don't think my blessing is needed for anything else.

[alexeypa (please no reviews), 2013-07-09 19:13:40]

ping!

erikwright@ - PTAL at src/chrome_frame/* - changes.
thestig@ - please rubberstump the rest for relanding.

[alexeypa (please no reviews), 2013-07-10 16:25:35]

On 2013/07/09 19:13:40, alexeypa wrote:
> ping!
> 
> erikwright@ - PTAL at src/chrome_frame/* - changes.
> thestig@ - please rubberstump the rest for relanding.

Trying different OWNERS this time:

chrome/* - thakis@
chrome_frame/* - robertshield@

[Nico, 2013-07-10 16:48:20]

chrome lgtm

https://codereview.chromium.org/18348025/diff/2001/chrome_frame/test/ui_test.cc
File chrome_frame/test/ui_test.cc (right):

https://codereview.chromium.org/18348025/diff/2001/chrome_frame/test/ui_test....
chrome_frame/test/ui_test.cc:474: // Destory the clipboard here because it is
not destroyed automatically.
typo Destory

[robertshield, 2013-07-10 17:21:07]

CF LGTM

https://codereview.chromium.org/18348025/diff/2001/base/win/message_window.h
File base/win/message_window.h (right):

https://codereview.chromium.org/18348025/diff/2001/base/win/message_window.h#...
base/win/message_window.h:48: // |windows_name|.
window_name

[alexeypa (please no reviews), 2013-07-10 19:24:45]

Thanks!

https://codereview.chromium.org/18348025/diff/2001/base/win/message_window.h
File base/win/message_window.h (right):

https://codereview.chromium.org/18348025/diff/2001/base/win/message_window.h#...
base/win/message_window.h:48: // |windows_name|.
On 2013/07/10 17:21:07, robertshield wrote:
> window_name

It is intentionally enclosed in pipes to emphasize that this is a C++
identifier. Comments in this whole file follow this style.

https://codereview.chromium.org/18348025/diff/2001/chrome_frame/test/ui_test.cc
File chrome_frame/test/ui_test.cc (right):

https://codereview.chromium.org/18348025/diff/2001/chrome_frame/test/ui_test....
chrome_frame/test/ui_test.cc:474: // Destory the clipboard here because it is
not destroyed automatically.
On 2013/07/10 16:48:20, Nico wrote:
> typo Destory

Done.

[commit-bot: I haz the power, 2013-07-10 19:27:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/18348025/25001

[robertshield, 2013-07-10 19:36:29]

https://codereview.chromium.org/18348025/diff/2001/base/win/message_window.h
File base/win/message_window.h (right):

https://codereview.chromium.org/18348025/diff/2001/base/win/message_window.h#...
base/win/message_window.h:48: // |windows_name|.
On 2013/07/10 19:24:45, alexeypa wrote:
> On 2013/07/10 17:21:07, robertshield wrote:
> > window_name
> 
> It is intentionally enclosed in pipes to emphasize that this is a C++
> identifier. Comments in this whole file follow this style.

I meant that it should be |window_name| rather than |windows_name|.

[alexeypa (please no reviews), 2013-07-10 19:41:59]

https://codereview.chromium.org/18348025/diff/2001/base/win/message_window.h
File base/win/message_window.h (right):

https://codereview.chromium.org/18348025/diff/2001/base/win/message_window.h#...
base/win/message_window.h:48: // |windows_name|.
On 2013/07/10 19:36:29, robertshield wrote:
> I meant that it should be |window_name| rather than |windows_name|.

Sorry, missed that. Done.

[commit-bot: I haz the power, 2013-07-10 19:42:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/18348025/28002

[commit-bot: I haz the power, 2013-07-10 19:53:39]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-07-10 20:06:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/18348025/28002

[commit-bot: I haz the power, 2013-07-11 03:22:52]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-07-11 03:31:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/18348025/28002

[commit-bot: I haz the power, 2013-07-11 06:13:47]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-07-11 06:21:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/18348025/28002

[commit-bot: I haz the power, 2013-07-11 09:22:40]

Change committed as 211049