Issue 18348021: Allow unsetting scroll client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18348021: Allow unsetting scroll client (Closed)

Created:
7 years, 5 months ago by enne (OOO)

Modified:
7 years, 5 months ago

Reviewers:
jamesr

CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, tfarina, Ian Vollick

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow unsetting scroll client Currently in Blink every GraphicsLayer sets the scroll client of its platform layer to be itself. This works because LayerTreeHost::ApplyScrollAndScaleSet doesn't end up calling the scroll client callback for root scroll layer scrolls and the callback is never used. I am going to change Blink to only set the scroll client for non-root scrollable layers so that the compositor can just always call the callback if it exists and doesn't have to be smart. In order to do this, it'd be nice to be able to unset the scroll client from Blink. R=jamesr@chromium.org BUG=256381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210089

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	webkit/renderer/compositor_bindings/web_layer_impl.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/18348021/1

7 years, 5 months ago (2013-07-03 22:24:07 UTC) #3

Message was sent while issue was closed.

Change committed as 210089

Expand Messages | Collapse Messages