If requested, report network interfaces to management server.

chrome/browser/chromeos/settings/device_settings_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_settings_provider.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/command_line.h"
@@ skipping 44 matching lines @@
   kDeviceAttestationEnabled,
   kDeviceOwner,
   kIdleLogoutTimeout,
   kIdleLogoutWarningDuration,
   kPolicyMissingMitigationMode,
   kReleaseChannel,
   kReleaseChannelDelegated,
   kReportDeviceActivityTimes,
   kReportDeviceBootMode,
   kReportDeviceLocation,
+  kReportDeviceNetworkInterfaces,
   kReportDeviceVersionInfo,
   kScreenSaverExtensionId,
   kScreenSaverTimeout,
   kSignedDataRoamingEnabled,
   kStartUpFlags,
   kStartUpUrls,
   kStatsReportingPref,
   kSystemTimezonePolicy,
   kUpdateDisabled,
   kVariationsRestrictParameter,
@@ skipping 296 matching lines @@
     //   kAppPack
     //   kDeviceAttestationEnabled
     //   kDeviceOwner
     //   kIdleLogoutTimeout
     //   kIdleLogoutWarningDuration
     //   kReleaseChannelDelegated
     //   kReportDeviceActivityTimes
     //   kReportDeviceBootMode
     //   kReportDeviceLocation
     //   kReportDeviceVersionInfo
+    //   kReportDeviceNetworkInterfaces
     //   kScreenSaverExtensionId
     //   kScreenSaverTimeout
     //   kStartUpUrls
     //   kSystemTimezonePolicy
     //   kVariationsRestrictParameter
 
     LOG(FATAL) << "Device setting " << prop << " is read-only.";
   }
 
   em::PolicyData data;
@@ skipping 235 matching lines @@
   for (RepeatedField<int>::const_iterator i = allowed_connection_types.begin(),
            e = allowed_connection_types.end(); i != e; ++i) {
     list->Append(new base::FundamentalValue(*i));
   }
   new_values_cache->SetValue(kAllowedConnectionTypesForUpdate, list);
 }
 
 void DeviceSettingsProvider::DecodeReportingPolicies(
     const em::ChromeDeviceSettingsProto& policy,
     PrefValueMap* new_values_cache) const {
   if (policy.has_device_reporting()) {

[pneubeck (no reviews), 2013/07/04 15:51:48]

nit:
could be negated and early return.

[Mattias Nissler (ping if slow), 2013/07/11 17:41:46]

That would make it inconsistent with the pattern all other functions in this
file use, and that have more than one top-level conditional. I instead fixed the
AU decoding function to comply with the dominant style.

     if (policy.device_reporting().has_report_version_info()) {

[pneubeck (no reviews), 2013/07/04 15:51:48]

nit:
and policy.device_reporting() could be assigned to a local variable.

[Mattias Nissler (ping if slow), 2013/07/11 17:41:46]

Done. Kept the formatting for consistency (the new block needs two line breaks).

       new_values_cache->SetBoolean(
           kReportDeviceVersionInfo,
           policy.device_reporting().report_version_info());
     }
     if (policy.device_reporting().has_report_activity_times()) {
       new_values_cache->SetBoolean(
           kReportDeviceActivityTimes,
           policy.device_reporting().report_activity_times());
     }
     if (policy.device_reporting().has_report_boot_mode()) {
       new_values_cache->SetBoolean(
           kReportDeviceBootMode,
           policy.device_reporting().report_boot_mode());
     }
     // Device location reporting needs to pass privacy review before it can be
     // enabled. crosbug.com/24681
     // if (policy.device_reporting().has_report_location()) {

[Greg Spencer (Chromium), 2013/07/08 21:44:18]

nit: I know you didn't add it here, but commented out code is not typically left
in.

[Mattias Nissler (ping if slow), 2013/07/11 17:41:46]

Removed.

     //   new_values_cache->SetBoolean(
     //       kReportDeviceLocation,
     //       policy.device_reporting().report_location());
     // }
+    if (policy.device_reporting().has_report_network_interfaces()) {
+      new_values_cache->SetBoolean(
+          kReportDeviceNetworkInterfaces,
+          policy.device_reporting().report_network_interfaces());
+    }
   }
 }
 
 void DeviceSettingsProvider::DecodeGenericPolicies(
     const em::ChromeDeviceSettingsProto& policy,
     PrefValueMap* new_values_cache) const {
   if (policy.has_metrics_enabled()) {
     new_values_cache->SetBoolean(kStatsReportingPref,
                                  policy.metrics_enabled().metrics_enabled());
   } else {
@@ skipping 283 matching lines @@
 void DeviceSettingsProvider::AttemptMigration() {
   if (device_settings_service_->HasPrivateOwnerKey()) {
     PrefValueMap::const_iterator i;
     for (i = migration_values_.begin(); i != migration_values_.end(); ++i)
       DoSet(i->first, *i->second);
     migration_values_.Clear();
   }
 }
 
 }  // namespace chromeos