Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 18348015: rebaseline.py self-tests: prepare to add tests of JSON-format rebaselining (Closed)

Created:
7 years, 5 months ago by epoger
Modified:
7 years, 5 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

rebaseline.py self-tests: prepare to add tests of JSON-format rebaselining For now, rebaseline.py still does not support JSON-format rebaselining, so the one self-test reports failure. But this change will allow us to test the JSON-format rebaselining once rebaseline.py supports it. R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=9896

Patch Set 1 #

Total comments: 3

Patch Set 2 : tinyfix #

Messages

Total messages: 3 (0 generated)
epoger
Ready for review at patchset 2. https://codereview.chromium.org/18348015/diff/1/tools/tests/rebaseline/output/using-json1-expectations/output-expected/command_line File tools/tests/rebaseline/output/using-json1-expectations/output-expected/command_line (right): https://codereview.chromium.org/18348015/diff/1/tools/tests/rebaseline/output/using-json1-expectations/output-expected/command_line#newcode1 tools/tests/rebaseline/output/using-json1-expectations/output-expected/command_line:1: python tools/rebaseline.py --expectations-root ...
7 years, 5 months ago (2013-07-03 17:00:07 UTC) #1
scroggo
lgtm
7 years, 5 months ago (2013-07-03 17:39:32 UTC) #2
epoger
7 years, 5 months ago (2013-07-03 17:43:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r9896 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698