Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1834783003: Added the SuppressUnsupportedOSWarning policy setting. (Closed)

Created:
4 years, 9 months ago by grt (UTC plus 2)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tnagel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added the SuppressUnsupportedOSWarning policy setting. When set, this suppresses the unsupported OS warning (a.k.a, ObsoleteSystemInfoBar). BUG=582262 Committed: https://crrev.com/a349cae3d63e650588498b5b9f298e25f6053903 Cr-Commit-Position: refs/heads/master@{#383467}

Patch Set 1 #

Patch Set 2 : fixed policy_test_cases #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +1 line, -0 lines 2 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 1 chunk +10 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 2 chunks +16 lines, -1 line 1 comment Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834783003/1
4 years, 9 months ago (2016-03-25 14:09:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834783003/20001
4 years, 9 months ago (2016-03-25 14:15:25 UTC) #7
grt (UTC plus 2)
PTAL. drew: policy sky: chrome/browser holte: histograms Thanks!
4 years, 9 months ago (2016-03-25 14:17:39 UTC) #8
sky
Could you outline why we want to suppress the warning?
4 years, 9 months ago (2016-03-25 15:48:41 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 16:15:00 UTC) #11
grt (UTC plus 2)
On 2016/03/25 15:48:41, sky wrote: > Could you outline why we want to suppress the ...
4 years, 9 months ago (2016-03-25 16:40:08 UTC) #12
sky
LGTM
4 years, 9 months ago (2016-03-25 16:51:19 UTC) #13
Steven Holte
lgtm
4 years, 9 months ago (2016-03-26 01:35:31 UTC) #14
Andrew T Wilson (Slow)
lgtm https://codereview.chromium.org/1834783003/diff/20001/chrome/browser/ui/startup/startup_browser_creator.cc File chrome/browser/ui/startup/startup_browser_creator.cc (right): https://codereview.chromium.org/1834783003/diff/20001/chrome/browser/ui/startup/startup_browser_creator.cc#newcode478 chrome/browser/ui/startup/startup_browser_creator.cc:478: registry->RegisterBooleanPref(prefs::kSuppressUnsupportedOSWarning, false); Should this be behind a !OS_ANDROID ...
4 years, 9 months ago (2016-03-27 09:28:44 UTC) #15
grt (UTC plus 2)
Thanks for the weekend review! https://codereview.chromium.org/1834783003/diff/20001/chrome/browser/ui/startup/startup_browser_creator.cc File chrome/browser/ui/startup/startup_browser_creator.cc (right): https://codereview.chromium.org/1834783003/diff/20001/chrome/browser/ui/startup/startup_browser_creator.cc#newcode478 chrome/browser/ui/startup/startup_browser_creator.cc:478: registry->RegisterBooleanPref(prefs::kSuppressUnsupportedOSWarning, false); On 2016/03/27 ...
4 years, 9 months ago (2016-03-27 13:03:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834783003/20001
4 years, 9 months ago (2016-03-27 13:05:21 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-27 14:20:28 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a349cae3d63e650588498b5b9f298e25f6053903 Cr-Commit-Position: refs/heads/master@{#383467}
4 years, 9 months ago (2016-03-27 14:22:14 UTC) #22
Thiemo Nagel
https://codereview.chromium.org/1834783003/diff/20001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/1834783003/diff/20001/components/policy/resources/policy_templates.json#newcode8368 components/policy/resources/policy_templates.json:8368: 'supported_on': ['chrome.*:49-','chrome_os:49-'], Does that really apply to Chrome OS? ...
4 years, 8 months ago (2016-03-30 16:13:04 UTC) #24
grt (UTC plus 2)
4 years, 8 months ago (2016-03-30 16:54:25 UTC) #25
Message was sent while issue was closed.
On 2016/03/30 16:13:04, Thiemo Nagel (no reviews) wrote:
>
https://codereview.chromium.org/1834783003/diff/20001/components/policy/resou...
> File components/policy/resources/policy_templates.json (right):
> 
>
https://codereview.chromium.org/1834783003/diff/20001/components/policy/resou...
> components/policy/resources/policy_templates.json:8368: 'supported_on':
> ['chrome.*:49-','chrome_os:49-'],
> Does that really apply to Chrome OS?  Under which circumstance do we currently
> display unsupported OS warnings on Chrome OS?

I don't know that we currently do. Since
browser/ui/startup/obsolete_system_infobar_delegate.cc is in
chrome_browser_ui.gypi's chrome_browser_ui_non_mobile_sources, I figured this
meant it was built on ChromeOS whether or not it is currently used. It seemed to
make sense for the policy to apply to all platforms where the feature is
included. If it is never and will never be used on ChromeOS, then it shouldn't
be built there, no?

Do you think it shouldn't be in the Chrome OS policy settings? What do we do on
ChromeOS when we drop support for old hardware?

Powered by Google App Engine
This is Rietveld 408576698