Added the SuppressUnsupportedOSWarning policy setting.

Added the SuppressUnsupportedOSWarning policy setting.

When set, this suppresses the unsupported OS warning (a.k.a,
ObsoleteSystemInfoBar).

BUG=582262
Committed: https://crrev.com/a349cae3d63e650588498b5b9f298e25f6053903
Cr-Commit-Position: refs/heads/master@{#383467}

[grt (UTC plus 2), 2016-03-25 14:08:48]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 14:09:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834783003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834783003/1

[grt (UTC plus 2), 2016-03-25 14:09:23]

Description was changed from

==========
Added the SuppressUnsupportedOSWarning policy setting.

When set, this suppresses the unsupported OS warning (a.k.a,
ObsoleteSystemInfoBar).

BUG=582262
==========

to

==========
Added the SuppressUnsupportedOSWarning policy setting.

When set, this suppresses the unsupported OS warning (a.k.a,
ObsoleteSystemInfoBar).

BUG=582262
==========

[grt (UTC plus 2), 2016-03-25 14:09:23]

grt@chromium.org changed reviewers:
+ atwilson@chromium.org

[grt (UTC plus 2), 2016-03-25 14:10:44]

grt@chromium.org changed reviewers:
+ holte@chromium.org, sky@chromium.org

[grt (UTC plus 2), 2016-03-25 14:15:15]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 14:15:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834783003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834783003/20001

[grt (UTC plus 2), 2016-03-25 14:17:39]

PTAL.
drew: policy
sky: chrome/browser
holte: histograms

Thanks!

[sky, 2016-03-25 15:48:41]

Could you outline why we want to suppress the warning?

[commit-bot: I haz the power, 2016-03-25 16:14:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 16:15:00]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2016-03-25 16:40:08]

On 2016/03/25 15:48:41, sky wrote:
> Could you outline why we want to suppress the warning?

Yes. Enterprises that are stuck with XP or body's wish for their users to not be
shown a message they can't do anything about.

[sky, 2016-03-25 16:51:19]

LGTM

[Steven Holte, 2016-03-26 01:35:31]

lgtm

[Andrew T Wilson (Slow), 2016-03-27 09:28:44]

lgtm

https://codereview.chromium.org/1834783003/diff/20001/chrome/browser/ui/start...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/1834783003/diff/20001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_browser_creator.cc:478:
registry->RegisterBooleanPref(prefs::kSuppressUnsupportedOSWarning, false);
Should this be behind a !OS_ANDROID flag?

[grt (UTC plus 2), 2016-03-27 13:03:51]

Thanks for the weekend review!

https://codereview.chromium.org/1834783003/diff/20001/chrome/browser/ui/start...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/1834783003/diff/20001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_browser_creator.cc:478:
registry->RegisterBooleanPref(prefs::kSuppressUnsupportedOSWarning, false);
On 2016/03/27 09:28:44, Andrew T Wilson (Slow) wrote:
> Should this be behind a !OS_ANDROID flag?

No. This cc file is in chrome_browser_ui_non_mobile_sources, so it isn't
compiled on Android or iOS. Thanks for checking.

[grt (UTC plus 2), 2016-03-27 13:05:11]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2016-03-27 13:05:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834783003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834783003/20001

[commit-bot: I haz the power, 2016-03-27 14:20:27]

Description was changed from

==========
Added the SuppressUnsupportedOSWarning policy setting.

When set, this suppresses the unsupported OS warning (a.k.a,
ObsoleteSystemInfoBar).

BUG=582262
==========

to

==========
Added the SuppressUnsupportedOSWarning policy setting.

When set, this suppresses the unsupported OS warning (a.k.a,
ObsoleteSystemInfoBar).

BUG=582262
==========

[commit-bot: I haz the power, 2016-03-27 14:20:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-27 14:22:13]

Description was changed from

==========
Added the SuppressUnsupportedOSWarning policy setting.

When set, this suppresses the unsupported OS warning (a.k.a,
ObsoleteSystemInfoBar).

BUG=582262
==========

to

==========
Added the SuppressUnsupportedOSWarning policy setting.

When set, this suppresses the unsupported OS warning (a.k.a,
ObsoleteSystemInfoBar).

BUG=582262

Committed: https://crrev.com/a349cae3d63e650588498b5b9f298e25f6053903
Cr-Commit-Position: refs/heads/master@{#383467}
==========

[commit-bot: I haz the power, 2016-03-27 14:22:14]

Patchset 2 (id:??) landed as
https://crrev.com/a349cae3d63e650588498b5b9f298e25f6053903
Cr-Commit-Position: refs/heads/master@{#383467}

[Thiemo Nagel, 2016-03-30 16:13:03]

tnagel@chromium.org changed reviewers:
+ tnagel@chromium.org

[Thiemo Nagel, 2016-03-30 16:13:04]

https://codereview.chromium.org/1834783003/diff/20001/components/policy/resou...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1834783003/diff/20001/components/policy/resou...
components/policy/resources/policy_templates.json:8368: 'supported_on':
['chrome.*:49-','chrome_os:49-'],
Does that really apply to Chrome OS?  Under which circumstance do we currently
display unsupported OS warnings on Chrome OS?

[grt (UTC plus 2), 2016-03-30 16:54:25]

On 2016/03/30 16:13:04, Thiemo Nagel (no reviews) wrote:
>
https://codereview.chromium.org/1834783003/diff/20001/components/policy/resou...
> File components/policy/resources/policy_templates.json (right):
> 
>
https://codereview.chromium.org/1834783003/diff/20001/components/policy/resou...
> components/policy/resources/policy_templates.json:8368: 'supported_on':
> ['chrome.*:49-','chrome_os:49-'],
> Does that really apply to Chrome OS?  Under which circumstance do we currently
> display unsupported OS warnings on Chrome OS?

I don't know that we currently do. Since
browser/ui/startup/obsolete_system_infobar_delegate.cc is in
chrome_browser_ui.gypi's chrome_browser_ui_non_mobile_sources, I figured this
meant it was built on ChromeOS whether or not it is currently used. It seemed to
make sense for the policy to apply to all platforms where the feature is
included. If it is never and will never be used on ChromeOS, then it shouldn't
be built there, no?

Do you think it shouldn't be in the Chrome OS policy settings? What do we do on
ChromeOS when we drop support for old hardware?