Remove font cache code

Delete font cache code and switch to font proxy by default.

This change will remove the font cache codepath. This also
removes support for the DirectWriteFontProxy field trial
(currently at 100% in all channels) and switches the font
proxy to be the default codepath.

BUG=525142
Committed: https://crrev.com/80b563a7c76146dd154f5c958cc3cb22ea7b7bc4
Cr-Commit-Position: refs/heads/master@{#384068}

[Ilya Kulshin, 2016-03-25 00:51:23]

Description was changed from

==========
Remove font cache code

BUG=
==========

to

==========
This change will remove the font cache codepath. This also
removes support for the DirectWriteFontProxy field trial
(currently at 100% in all channels) and switches the font
proxy to be the default codepath.

BUG=525142
==========

[Ilya Kulshin, 2016-03-25 01:06:49]

kulshin@chromium.org changed reviewers:
+ jochen@chromium.org, jschuh@chromium.org, scottmg@chromium.org

[Ilya Kulshin, 2016-03-25 01:06:49]

ptal

jschuh@ - chrome/common/chrome_utility_messages.h and
content/common/sandbox_win.cc
jochen@ - chrome/browser/*, chrome/utility/*, content/*.

[jschuh, 2016-03-25 13:57:56]

On 2016/03/25 01:06:49, Ilya Kulshin wrote:
> ptal
> 
> jschuh@ - chrome/common/chrome_utility_messages.h and
> content/common/sandbox_win.cc
> jochen@ - chrome/browser/*, chrome/utility/*, content/*.

Lgtm on removing the message and sandbox policy exception. Please have scottmg
or ananta review the patch overall before landing.

[Ilya Kulshin, 2016-03-25 18:49:31]

kulshin@chromium.org changed reviewers:
+ ananta@chromium.org

[ananta, 2016-03-28 21:37:27]

lgtm

[Ilya Kulshin, 2016-03-28 21:43:00]

The CQ bit was checked by kulshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 21:43:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834763003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834763003/40001

[commit-bot: I haz the power, 2016-03-28 22:49:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 22:49:27]

Dry run: This issue passed the CQ dry run.

[scottmg, 2016-03-29 17:36:28]

(Sorry, was Easter holiday here)

Nice!

good-riddance-lgtm

[Ilya Kulshin, 2016-03-29 19:20:15]

Description was changed from

==========
This change will remove the font cache codepath. This also
removes support for the DirectWriteFontProxy field trial
(currently at 100% in all channels) and switches the font
proxy to be the default codepath.

BUG=525142
==========

to

==========
Delete font cache code and switch to font proxy by default.

This change will remove the font cache codepath. This also
removes support for the DirectWriteFontProxy field trial
(currently at 100% in all channels) and switches the font
proxy to be the default codepath.

BUG=525142
==========

[jochen (gone - plz use gerrit), 2016-03-30 16:31:47]

lgtm

[Ilya Kulshin, 2016-03-30 18:32:11]

The CQ bit was checked by kulshin@chromium.org

[commit-bot: I haz the power, 2016-03-30 18:32:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834763003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834763003/40001

[commit-bot: I haz the power, 2016-03-30 20:05:27]

Description was changed from

==========
Delete font cache code and switch to font proxy by default.

This change will remove the font cache codepath. This also
removes support for the DirectWriteFontProxy field trial
(currently at 100% in all channels) and switches the font
proxy to be the default codepath.

BUG=525142
==========

to

==========
Delete font cache code and switch to font proxy by default.

This change will remove the font cache codepath. This also
removes support for the DirectWriteFontProxy field trial
(currently at 100% in all channels) and switches the font
proxy to be the default codepath.

BUG=525142
==========

[commit-bot: I haz the power, 2016-03-30 20:05:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-30 20:07:26]

Description was changed from

==========
Delete font cache code and switch to font proxy by default.

This change will remove the font cache codepath. This also
removes support for the DirectWriteFontProxy field trial
(currently at 100% in all channels) and switches the font
proxy to be the default codepath.

BUG=525142
==========

to

==========
Delete font cache code and switch to font proxy by default.

This change will remove the font cache codepath. This also
removes support for the DirectWriteFontProxy field trial
(currently at 100% in all channels) and switches the font
proxy to be the default codepath.

BUG=525142

Committed: https://crrev.com/80b563a7c76146dd154f5c958cc3cb22ea7b7bc4
Cr-Commit-Position: refs/heads/master@{#384068}
==========

[commit-bot: I haz the power, 2016-03-30 20:07:27]

Patchset 3 (id:??) landed as
https://crrev.com/80b563a7c76146dd154f5c958cc3cb22ea7b7bc4
Cr-Commit-Position: refs/heads/master@{#384068}

[Devlin, 2016-03-30 21:44:48]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1845063002/ by rdevlin.cronin@chromium.org.

The reason for reverting is: Speculative revert for causing failures:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8216.

[gab, 2016-04-06 14:25:22]

gab@chromium.org changed reviewers:
+ gab@chromium.org

[gab, 2016-04-06 14:25:23]

https://codereview.chromium.org/1834763003/diff/40001/content/common/dwrite_f...
File content/common/dwrite_font_platform_win.cc (left):

https://codereview.chromium.org/1834763003/diff/40001/content/common/dwrite_f...
content/common/dwrite_font_platform_win.cc:1101: const char
kFontCacheSharedSectionName[] = "ChromeDWriteFontCache";
AFAICT this file isn't being cleaned up by this CL. Please follow-up with a CL
to add cleanup code for a couple of milestones (a TODO with date to remove in a
year is what we typically do for prefs, seems reasonable for a file too).

[gab, 2016-04-11 15:16:09]

On 2016/04/06 14:25:23, gab wrote:
>
https://codereview.chromium.org/1834763003/diff/40001/content/common/dwrite_f...
> File content/common/dwrite_font_platform_win.cc (left):
> 
>
https://codereview.chromium.org/1834763003/diff/40001/content/common/dwrite_f...
> content/common/dwrite_font_platform_win.cc:1101: const char
> kFontCacheSharedSectionName[] = "ChromeDWriteFontCache";
> AFAICT this file isn't being cleaned up by this CL. Please follow-up with a CL
> to add cleanup code for a couple of milestones (a TODO with date to remove in
a
> year is what we typically do for prefs, seems reasonable for a file too).

ping, thanks

[Ilya Kulshin, 2016-04-11 19:07:21]

On 2016/04/11 15:16:09, gab wrote:
> On 2016/04/06 14:25:23, gab wrote:
> >
>
https://codereview.chromium.org/1834763003/diff/40001/content/common/dwrite_f...
> > File content/common/dwrite_font_platform_win.cc (left):
> > 
> >
>
https://codereview.chromium.org/1834763003/diff/40001/content/common/dwrite_f...
> > content/common/dwrite_font_platform_win.cc:1101: const char
> > kFontCacheSharedSectionName[] = "ChromeDWriteFontCache";
> > AFAICT this file isn't being cleaned up by this CL. Please follow-up with a
CL
> > to add cleanup code for a couple of milestones (a TODO with date to remove
in
> a
> > year is what we typically do for prefs, seems reasonable for a file too).
> 
> ping, thanks

Was planning on doing that as part of bug 559333, but logged crbug.com/602387
anyway, to make sure I don't forget.