Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: appengine/findit/templates/build_failure.html

Issue 1834703004: [Findit] Fix undefined in result page. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <head> 2 <head>
3 <title>Build Failure</title> 3 <title>Build Failure</title>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <link rel="stylesheet" href="/common.css"> 5 <link rel="stylesheet" href="/common.css">
6 <style> 6 <style>
7 .running { 7 .running {
8 color: #666666; 8 color: #666666;
9 background-color: #fffc6c; 9 background-color: #fffc6c;
10 border-color: #c5c56d; 10 border-color: #c5c56d;
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 }); 335 });
336 } 336 }
337 337
338 function displayTryJobResult() { 338 function displayTryJobResult() {
339 $.getJSON('try-job-result?url=' + findit.buildUrl, function(data) { 339 $.getJSON('try-job-result?url=' + findit.buildUrl, function(data) {
340 if (! jQuery.isEmptyObject(data)) { 340 if (! jQuery.isEmptyObject(data)) {
341 var tableString = '<table><tr><th>Step</th><th>Test</th><th>Link</th ><th>Status</th><th>Culprit</th></tr>'; 341 var tableString = '<table><tr><th>Step</th><th>Test</th><th>Link</th ><th>Status</th><th>Culprit</th></tr>';
342 var hasTryJobData = false; 342 var hasTryJobData = false;
343 $.each(data, function(key, value) { 343 $.each(data, function(key, value) {
344 tableString += '<tr>'; 344 tableString += '<tr>';
345 tableString += '<td>' + value.step + '</td>'; 345 tableString += '<td>' + value.step_name + '</td>';
346 tableString += '<td><li><div title="' + value.test + '" class="tru ncate">' + value.test + '</div></li></td>'; 346 tableString += '<td><li><div title="' + value.test_name + '" class ="truncate">' + value.test_name + '</div></li></td>';
347 if (value.try_job_url) { 347 if (value.try_job_url) {
348 tableString += '<td><a href="' + value.try_job_url + '">' + valu e.try_job_build_number + '</a></td>'; 348 tableString += '<td><a href="' + value.try_job_url + '">' + valu e.try_job_build_number + '</a></td>';
349 } else { 349 } else {
350 tableString += '<td></td>'; 350 tableString += '<td></td>';
351 } 351 }
352 352
353 if (value.status) { 353 if (value.status) {
354 hasTryJobData = true; 354 hasTryJobData = true;
355 } else { 355 } else {
356 return true; // Broken data, continue to next one. 356 return true; // Broken data, continue to next one.
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 appearing in the failure log. (eg: file.h was changed and 583 appearing in the failure log. (eg: file.h was changed and
584 file_unittest.cc or file_impl.cc appeared in the log.)</li> 584 file_unittest.cc or file_impl.cc appeared in the log.)</li>
585 <li>1: The CL rolled a dependency within src/DEPS and a file of that 585 <li>1: The CL rolled a dependency within src/DEPS and a file of that
586 dependency appears in the failure log. (eg: third_party/dep 586 dependency appears in the failure log. (eg: third_party/dep
587 was changed in src/DEPS and third_party/dep/f.cpp appeared 587 was changed in src/DEPS and third_party/dep/f.cpp appeared
588 in the log.)</li> 588 in the log.)</li>
589 </ul> 589 </ul>
590 (More rules will be added when implemented.) 590 (More rules will be added when implemented.)
591 </div> 591 </div>
592 </body> 592 </body>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698