Fix preferred width calculation for 8bit ltr runs in rtl blocks

Fix preferred width calculation for 8bit ltr runs in rtl blocks

Fix trigger criteria in LayoutText::computePreferredLogicalWidths for 8-
bit runs. Before all 8-bit runs without explciit directionality override
was assumed to have the same fixed direction. This failed in cases where
the text direction had been specified for the parent block (direction:).

This caused RTL font metrics to be used to determine the preferred width
but LTR metrics to compute line breaking, resulting in incorrect breaks.

TEST=fast/text/ltr-text-in-rtl-8bit-block.html,
     fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html
BUG=589525
R=szager@chromium.org

Committed: https://crrev.com/5ba3aaa03c4a14575babc54240831d713975d8ca
Cr-Commit-Position: refs/heads/master@{#383175}

[szager1, 2016-03-24 18:01:47]

lgtm

[eae, 2016-03-24 19:23:54]

The CQ bit was checked by eae@chromium.org

[eae, 2016-03-24 19:23:55]

The patchset sent to the CQ was uploaded after l-g-t-m from szager@chromium.org
Link to the patchset: https://codereview.chromium.org/1834703002/#ps20001
(title: "w/TestExpectations")

[commit-bot: I haz the power, 2016-03-24 19:24:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834703002/20001

[eae, 2016-03-24 21:36:29]

The CQ bit was checked by eae@chromium.org

[eae, 2016-03-24 21:36:30]

The patchset sent to the CQ was uploaded after l-g-t-m from szager@chromium.org
Link to the patchset: https://codereview.chromium.org/1834703002/#ps40001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-03-24 21:36:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834703002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834703002/40001

[commit-bot: I haz the power, 2016-03-24 22:54:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-24 22:56:23]

Description was changed from

==========
Fix preferred width calculation for 8bit ltr runs in rtl blocks

Fix trigger criteria in LayoutText::computePreferredLogicalWidths for 8-
bit runs. Before all 8-bit runs without explciit directionality override
was assumed to have the same fixed direction. This failed in cases where
the text direction had been specified for the parent block (direction:).

This caused RTL font metrics to be used to determine the preferred width
but LTR metrics to compute line breaking, resulting in incorrect breaks.

TEST=fast/text/ltr-text-in-rtl-8bit-block.html,
     fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html
BUG=589525
R=szager@chromium.org
==========

to

==========
Fix preferred width calculation for 8bit ltr runs in rtl blocks

Fix trigger criteria in LayoutText::computePreferredLogicalWidths for 8-
bit runs. Before all 8-bit runs without explciit directionality override
was assumed to have the same fixed direction. This failed in cases where
the text direction had been specified for the parent block (direction:).

This caused RTL font metrics to be used to determine the preferred width
but LTR metrics to compute line breaking, resulting in incorrect breaks.

TEST=fast/text/ltr-text-in-rtl-8bit-block.html,
     fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html
BUG=589525
R=szager@chromium.org

Committed: https://crrev.com/5ba3aaa03c4a14575babc54240831d713975d8ca
Cr-Commit-Position: refs/heads/master@{#383175}
==========

[commit-bot: I haz the power, 2016-03-24 22:56:24]

Patchset 3 (id:??) landed as
https://crrev.com/5ba3aaa03c4a14575babc54240831d713975d8ca
Cr-Commit-Position: refs/heads/master@{#383175}