Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18347003: DevTools: Implement CSS pretty-printing (Closed)

Created:
7 years, 5 months ago by apavlov
Modified:
7 years, 2 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Implement CSS pretty-printing R=pfeldman, vsevik BUG=163123 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158716

Patch Set 1 : Rebased #

Patch Set 2 : Rebased #

Total comments: 4

Patch Set 3 : Comments addressed #

Total comments: 5

Patch Set 4 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1059 lines, -414 lines) Patch
A LayoutTests/inspector/styles/resources/style-formatter-obfuscated.css View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/inspector/styles/style-formatter.html View 1 1 chunk +104 lines, -0 lines 0 comments Download
A LayoutTests/inspector/styles/style-formatter-expected.txt View 1 chunk +31 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A Source/devtools/front_end/CSSFormatter.js View 1 2 3 1 chunk +291 lines, -0 lines 0 comments Download
M Source/devtools/front_end/JavaScriptFormatter.js View 1 2 3 29 chunks +495 lines, -386 lines 0 comments Download
M Source/devtools/front_end/ScriptFormatter.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ScriptFormatterWorker.js View 1 2 3 7 chunks +131 lines, -27 lines 0 comments Download
M Source/devtools/front_end/externs.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
apavlov
7 years, 5 months ago (2013-07-01 11:56:40 UTC) #1
apavlov
Friendly ping
7 years, 5 months ago (2013-07-15 14:38:29 UTC) #2
apavlov
Now that we have the lazy binding of CSS LiveLocations in place, and CodeMirror modes ...
7 years, 2 months ago (2013-09-30 09:34:09 UTC) #3
pfeldman
https://codereview.chromium.org/18347003/diff/9001/Source/devtools/front_end/CSSFormatter.js File Source/devtools/front_end/CSSFormatter.js (right): https://codereview.chromium.org/18347003/diff/9001/Source/devtools/front_end/CSSFormatter.js#newcode31 Source/devtools/front_end/CSSFormatter.js:31: function CSSFormattedContentBuilder(content, mapping, originalOffset, formattedOffset, indentString) Please annotate. https://codereview.chromium.org/18347003/diff/9001/Source/devtools/front_end/CSSFormatter.js#newcode182 ...
7 years, 2 months ago (2013-09-30 12:07:25 UTC) #4
apavlov
https://codereview.chromium.org/18347003/diff/9001/Source/devtools/front_end/CSSFormatter.js File Source/devtools/front_end/CSSFormatter.js (right): https://codereview.chromium.org/18347003/diff/9001/Source/devtools/front_end/CSSFormatter.js#newcode31 Source/devtools/front_end/CSSFormatter.js:31: function CSSFormattedContentBuilder(content, mapping, originalOffset, formattedOffset, indentString) On 2013/09/30 12:07:26, ...
7 years, 2 months ago (2013-09-30 12:50:29 UTC) #5
pfeldman
lgtm https://codereview.chromium.org/18347003/diff/15001/Source/devtools/front_end/CSSFormatter.js File Source/devtools/front_end/CSSFormatter.js (right): https://codereview.chromium.org/18347003/diff/15001/Source/devtools/front_end/CSSFormatter.js#newcode276 Source/devtools/front_end/CSSFormatter.js:276: function findAll(text, string) Why are these global? https://codereview.chromium.org/18347003/diff/15001/Source/devtools/front_end/CSSFormatter.js#newcode290 ...
7 years, 2 months ago (2013-09-30 15:46:06 UTC) #6
vsevik
https://chromiumcodereview.appspot.com/18347003/diff/15001/Source/devtools/front_end/ScriptFormatterWorker.js File Source/devtools/front_end/ScriptFormatterWorker.js (right): https://chromiumcodereview.appspot.com/18347003/diff/15001/Source/devtools/front_end/ScriptFormatterWorker.js#newcode214 Source/devtools/front_end/ScriptFormatterWorker.js:214: HTMLScriptFormatter = function(indentString) HTMLFormatter? https://chromiumcodereview.appspot.com/18347003/diff/15001/Source/devtools/front_end/StylesSourceMapping.js File Source/devtools/front_end/StylesSourceMapping.js (right): https://chromiumcodereview.appspot.com/18347003/diff/15001/Source/devtools/front_end/StylesSourceMapping.js#newcode210 ...
7 years, 2 months ago (2013-09-30 16:12:12 UTC) #7
apavlov
All comments addressed in patchset 4
7 years, 2 months ago (2013-10-01 10:12:15 UTC) #8
vsevik
lgtm
7 years, 2 months ago (2013-10-02 10:40:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/18347003/24001
7 years, 2 months ago (2013-10-02 10:43:24 UTC) #10
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 12:29:04 UTC) #11
Message was sent while issue was closed. 
Change committed as 158716

Powered by Google App Engine
This is Rietveld 408576698