Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1834673003: Do not compile a class when the class mirror tries to access the metadata. (Closed)

Created:
4 years, 9 months ago by siva
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not compile a class when the class mirror tries to access the metadata. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/341643cb2bcaa297bc83e5329120cdc6e8202e7a

Patch Set 1 #

Patch Set 2 : experiment #

Patch Set 3 : undo-changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M runtime/lib/mirrors.cc View 5 chunks +23 lines, -6 lines 0 comments Download
M tests/lib/mirrors/mirror_in_static_init_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 8 months ago (2016-03-28 00:59:14 UTC) #2
rmacnak
lgtm
4 years, 8 months ago (2016-03-28 17:27:38 UTC) #3
siva
4 years, 8 months ago (2016-03-28 18:16:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
341643cb2bcaa297bc83e5329120cdc6e8202e7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698