Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1834673002: Don't force lcd on non-opaque portion of layer. (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't force lcd on non-opaque portion of layer. SkCanvas::saveLayerPreserveLCDTextRequests allows for lcd in layers but forces the user to ensure that the lcd text is only drawn on opaque parts of the layer. Otherwise the behavior is more or less undefined. This GM did this on purpose to demonstrate, but it turns out this is unstable and depends on the alignment of the glyph masks in CPU. Since we don't support this mode anyway, drop it from the gm. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834673002 Committed: https://skia.googlesource.com/skia/+/4b32360f4456af2b62f3fd37ed6f049a8037e47a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M gm/lcdtext.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834673002/1
4 years, 9 months ago (2016-03-24 14:40:50 UTC) #4
bungeman-skia
4 years, 9 months ago (2016-03-24 14:41:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 14:52:03 UTC) #9
bsalomon
lgtm
4 years, 9 months ago (2016-03-24 14:53:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834673002/1
4 years, 9 months ago (2016-03-24 15:17:01 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 15:17:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4b32360f4456af2b62f3fd37ed6f049a8037e47a

Powered by Google App Engine
This is Rietveld 408576698