Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1834643002: ozone: Avoid using gbm_bo_import until import and destroy can be synchronized. (Closed)

Created:
4 years, 9 months ago by reveman
Modified:
4 years, 8 months ago
Reviewers:
spang
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, lpique, ozone-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Avoid using gbm_bo_import until import and destroy can be synchronized. The client needs to be able to synchronize destruction and import of buffers before gbm_bo_import can be used as otherwise importing a buffer a second time might return the same GEM handle. BUG=597932 Committed: https://crrev.com/a54ebb6919a4b484f5d58f92c6953a62e8f8a6b3 Cr-Commit-Position: refs/heads/master@{#383988}

Patch Set 1 #

Patch Set 2 : temporary removal of gbm_bo_import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -36 lines) Patch
M ui/ozone/platform/drm/gpu/gbm_buffer.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 1 4 chunks +11 lines, -35 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834643002/20001
4 years, 9 months ago (2016-03-25 13:48:21 UTC) #3
reveman
4 years, 9 months ago (2016-03-25 13:48:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 14:23:59 UTC) #7
reveman
spang ping for review. fyi, this is P0 b/27443898
4 years, 8 months ago (2016-03-30 09:06:49 UTC) #8
spang
lgtm
4 years, 8 months ago (2016-03-30 14:49:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834643002/20001
4 years, 8 months ago (2016-03-30 15:23:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 16:07:12 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 16:08:17 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a54ebb6919a4b484f5d58f92c6953a62e8f8a6b3
Cr-Commit-Position: refs/heads/master@{#383988}

Powered by Google App Engine
This is Rietveld 408576698