Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: src/debug/debug-scopes.h

Issue 1834633003: [debugger] allow debug-evaluate to change stack and context values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug-scopes.h
diff --git a/src/debug/debug-scopes.h b/src/debug/debug-scopes.h
index 80e19810e742f897731e9f80394304e6afba0207..f3b79b9645dee20707d1fe449dff8d36576e44d5 100644
--- a/src/debug/debug-scopes.h
+++ b/src/debug/debug-scopes.h
@@ -43,8 +43,6 @@ class ScopeIterator {
ScopeIterator(Isolate* isolate, Handle<JSFunction> function);
- ~ScopeIterator() { delete non_locals_; }
-
MUST_USE_RESULT MaybeHandle<JSObject> MaterializeScopeDetails();
// More scopes?
@@ -75,10 +73,8 @@ class ScopeIterator {
// be an actual context.
Handle<Context> CurrentContext();
- // Populate the list with collected non-local variable names.
- void GetNonLocals(List<Handle<String> >* list_out);
-
- bool ThisIsNonLocal();
+ // Populate the set with collected non-local variable names.
+ Handle<StringSet> GetNonLocals();
#ifdef DEBUG
// Debug print of the content of the current scope.
@@ -98,7 +94,7 @@ class ScopeIterator {
FrameInspector* const frame_inspector_;
Handle<Context> context_;
List<ExtendedScopeInfo> nested_scope_chain_;
- HashMap* non_locals_;
+ Handle<StringSet> non_locals_;
bool seen_script_scope_;
bool failed_;
@@ -110,14 +106,6 @@ class ScopeIterator {
return Handle<JSFunction>::cast(frame_inspector_->GetFunction());
}
- static bool InternalizedStringMatch(void* key1, void* key2) {
- Handle<String> s1(reinterpret_cast<String**>(key1));
- Handle<String> s2(reinterpret_cast<String**>(key2));
- DCHECK(s1->IsInternalizedString());
- DCHECK(s2->IsInternalizedString());
- return s1.is_identical_to(s2);
- }
-
void RetrieveScopeChain(Scope* scope);
void CollectNonLocals(Scope* scope);
« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698