Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: Source/core/dom/IdTargetObserverRegistry.h

Issue 183463004: Store IdTargetObserver::m_registry as a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/IdTargetObserver.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All Rights Reserved. 2 * Copyright (C) 2012 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 19 matching lines...) Expand all
30 #include "wtf/HashMap.h" 30 #include "wtf/HashMap.h"
31 #include "wtf/HashSet.h" 31 #include "wtf/HashSet.h"
32 #include "wtf/PassOwnPtr.h" 32 #include "wtf/PassOwnPtr.h"
33 #include "wtf/text/StringHash.h" 33 #include "wtf/text/StringHash.h"
34 34
35 namespace WebCore { 35 namespace WebCore {
36 36
37 class IdTargetObserver; 37 class IdTargetObserver;
38 38
39 class IdTargetObserverRegistry { 39 class IdTargetObserverRegistry {
40 WTF_MAKE_FAST_ALLOCATED; 40 WTF_MAKE_NONCOPYABLE(IdTargetObserverRegistry); WTF_MAKE_FAST_ALLOCATED;
41 friend class IdTargetObserver; 41 friend class IdTargetObserver;
42 public: 42 public:
43 static PassOwnPtr<IdTargetObserverRegistry> create(); 43 static PassOwnPtr<IdTargetObserverRegistry> create();
44 void notifyObservers(const AtomicString& id); 44 void notifyObservers(const AtomicString& id);
45 bool hasObservers(const AtomicString& id) const; 45 bool hasObservers(const AtomicString& id) const;
46 46
47 private: 47 private:
48 IdTargetObserverRegistry() : m_notifyingObserversInSet(0) { } 48 IdTargetObserverRegistry() : m_notifyingObserversInSet(0) { }
49 void addObserver(const AtomicString& id, IdTargetObserver*); 49 void addObserver(const AtomicString& id, IdTargetObserver*);
50 void removeObserver(const AtomicString& id, IdTargetObserver*); 50 void removeObserver(const AtomicString& id, IdTargetObserver*);
51 void notifyObserversInternal(const AtomicString& id); 51 void notifyObserversInternal(const AtomicString& id);
52 52
53 typedef HashSet<IdTargetObserver*> ObserverSet; 53 typedef HashSet<IdTargetObserver*> ObserverSet;
54 typedef HashMap<StringImpl*, OwnPtr<ObserverSet> > IdToObserverSetMap; 54 typedef HashMap<StringImpl*, OwnPtr<ObserverSet> > IdToObserverSetMap;
55 IdToObserverSetMap m_registry; 55 IdToObserverSetMap m_registry;
56 ObserverSet* m_notifyingObserversInSet; 56 ObserverSet* m_notifyingObserversInSet;
57 }; 57 };
58 58
59 inline void IdTargetObserverRegistry::notifyObservers(const AtomicString& id) 59 inline void IdTargetObserverRegistry::notifyObservers(const AtomicString& id)
60 { 60 {
61 ASSERT(!m_notifyingObserversInSet); 61 ASSERT(!m_notifyingObserversInSet);
62 if (id.isEmpty() || m_registry.isEmpty()) 62 if (id.isEmpty() || m_registry.isEmpty())
63 return; 63 return;
64 IdTargetObserverRegistry::notifyObserversInternal(id); 64 IdTargetObserverRegistry::notifyObserversInternal(id);
65 } 65 }
66 66
67 } // namespace WebCore 67 } // namespace WebCore
68 68
69 #endif // IdTargetObserverRegistry_h 69 #endif // IdTargetObserverRegistry_h
OLDNEW
« no previous file with comments | « Source/core/dom/IdTargetObserver.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698