Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 183463004: Store IdTargetObserver::m_registry as a reference (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk, rwlbuis
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis
Visibility:
Public.

Description

Store IdTargetObserver::m_registry as a reference Store IdTargetObserver::m_registry as a reference instead of a pointer. This makes the code look safer and gets rid of an unnecessary null check. Also make IdTargetObserverRegistry non copyable to protect against bad assignments to references. R=adamk@chromium.org, adamk, rwlbuis Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168419

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M Source/core/dom/IdTargetObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdTargetObserver.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 9 months ago (2014-03-04 03:13:58 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-04 05:00:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/183463004/1
6 years, 9 months ago (2014-03-04 05:00:37 UTC) #3
Inactive
6 years, 9 months ago (2014-03-05 02:47:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r168419 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698