Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1834613003: [elements] add fast-path for slice with FastSloppyArguments (Closed)

Created:
4 years, 9 months ago by Camillo Bruni
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements] add fast-path for slice with FastSloppyArguments BUG= Committed: https://crrev.com/604f5be5f7325ea1af817868695436b803969e8b Cr-Commit-Position: refs/heads/master@{#35300}

Patch Set 1 #

Patch Set 2 : fixing OOB #

Total comments: 1

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -10 lines) Patch
M src/builtins.cc View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
M src/elements.cc View 1 2 chunks +35 lines, -5 lines 0 comments Download
M test/mjsunit/array-slice.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834613003/1
4 years, 9 months ago (2016-03-24 14:36:24 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/3434) v8_linux_dbg_ng_triggered on ...
4 years, 9 months ago (2016-03-24 15:15:51 UTC) #4
Camillo Bruni
PTAL, seems to be used frequently on some websites
4 years, 8 months ago (2016-04-04 09:27:45 UTC) #6
Jakob Kummerow
lgtm https://codereview.chromium.org/1834613003/diff/20001/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1834613003/diff/20001/src/builtins.cc#newcode680 src/builtins.cc:680: // Treat it in C++ as well.S s/S//
4 years, 8 months ago (2016-04-06 11:02:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834613003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834613003/40001
4 years, 8 months ago (2016-04-06 13:01:21 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-06 13:29:52 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 13:30:15 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/604f5be5f7325ea1af817868695436b803969e8b
Cr-Commit-Position: refs/heads/master@{#35300}

Powered by Google App Engine
This is Rietveld 408576698