Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 18346: Adds support for multiple malware/phishing resources in a page (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.h
===================================================================
--- chrome/browser/safe_browsing/safe_browsing_service.h (revision 8521)
+++ chrome/browser/safe_browsing/safe_browsing_service.h (working copy)
@@ -57,14 +57,13 @@
// Structure used to pass parameters between the IO and UI thread when
// interacting with the blocking page.
- struct BlockingPageParam {
+ struct UnsafeResource {
GURL url;
- bool proceed;
- UrlCheckResult result;
+ ResourceType::Type resource_type;
+ UrlCheckResult threat_type;
Client* client;
int render_process_host_id;
int render_view_id;
- ResourceType::Type resource_type;
};
// Creates the safe browsing service. Need to initialize before using.
@@ -142,7 +141,8 @@
void UpdateFinished(bool update_succeeded);
// The blocking page on the UI thread has completed.
- void OnBlockingPageDone(const BlockingPageParam& param);
+ void OnBlockingPageDone(const std::vector<UnsafeResource>& resources,
+ bool proceed);
// Called when the SafeBrowsingProtocolManager has received updated MAC keys.
void OnNewMacKeys(const std::string& client_key,
@@ -242,7 +242,7 @@
void HandleResume();
// Invoked on the UI thread to show the blocking page.
- void DoDisplayBlockingPage(const BlockingPageParam& param);
+ void DoDisplayBlockingPage(const UnsafeResource& resource);
// During a reset or the initial load we may have to queue checks until the
// database is ready. This method is run once the database has loaded (or if
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698