components/offline_pages/BUILD.gn - Issue 1834563002: initial add of SQL based storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/BUILD.gn

Issue 1834563002: initial add of SQL based storage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/BUILD.gn

diff --git a/components/offline_pages/BUILD.gn b/components/offline_pages/BUILD.gn

index 94a9d75a8f624a9c75590a20e90eac4811002861..02e41df55586e7e8a495fb53fc80f639a5d13c46 100644

--- a/components/offline_pages/BUILD.gn

+++ b/components/offline_pages/BUILD.gn

@@ -16,6 +16,8 @@ static_library("offline_pages") {

"offline_page_metadata_store.h",

"offline_page_metadata_store_impl.cc",

"offline_page_metadata_store_impl.h",

+ "offline_page_metadata_store_sql.cc",

+ "offline_page_metadata_store_sql.h",

"offline_page_model.cc",

"offline_page_model.h",

"snapshot_controller.cc",

@@ -30,6 +32,7 @@ static_library("offline_pages") {

"//components/leveldb_proto",

"//components/offline_pages/proto:offline_pages_proto",

"//net",

+ "//sql:sql",

"//third_party/leveldatabase",

"//url",

]

@@ -81,6 +84,7 @@ source_set("unit_tests") {

"//base/test:test_support",

"//components/leveldb_proto",

"//components/offline_pages/proto:offline_pages_proto",

+ "//sql:sql",

"//testing/gtest",

"//url",

]