Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1847)

Issue 1834543002: Fix all strong-mode warnings. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/matcher@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix all strong-mode warnings. R=kevmoo@google.com

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
A .analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/iterable_matchers.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/operator_matchers.dart View 1 1 chunk +5 lines, -21 lines 0 comments Download
M lib/src/util.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 7 months ago (2016-03-23 23:35:43 UTC) #1
kevmoo
also, LGTM :-)
4 years, 7 months ago (2016-03-24 03:27:47 UTC) #2
kevmoo
still LGTM :-)
4 years, 6 months ago (2016-04-23 00:37:37 UTC) #3
nweiz
4 years, 6 months ago (2016-04-25 17:37:56 UTC) #4
On 2016/04/23 00:37:37, kevmoo wrote:
> still LGTM :-)

This landed via pull request:
https://github.com/dart-lang/matcher/commit/72f0767d15db96c82f0266eff812fe77f...

Powered by Google App Engine
This is Rietveld 408576698