Fix generated dart bindings for view_provider.

Fix generated dart bindings for view_provider.

Previously:
`NoSuchMethodError: method not found: 'view_token_mojom'`

There's probably a bug in the dart bindings generator that imports of
views.mojom aren't made available here.

BUG=
R=azani@chromium.org, jeffbrown@google.com, rudominer@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/31c5037ab2c63649632c9f2d4227ebe6f22015a4

[tonyg, 2016-03-23 22:56:33]

Description was changed from

==========
Fix generated dart bindings for view_provider.

Previously:
`NoSuchMethodError: method not found: 'view_token_mojom'`

There's probably a bug in the dart bindings generator that imports of
views.mojom aren't made available here.

BUG=
==========

to

==========
Fix generated dart bindings for view_provider.

Previously:
`NoSuchMethodError: method not found: 'view_token_mojom'`

There's probably a bug in the dart bindings generator that imports of
views.mojom aren't made available here.

BUG=
==========

[tonyg, 2016-03-23 22:56:33]

tonyg@chromium.org changed reviewers:
+ azani@chromium.org, rudominer@chromium.org, zra@google.com

[tonyg, 2016-03-23 22:57:02]

Would anyone mind rolling this mojo_services pub after this lands?

[azani, 2016-03-23 23:08:46]

lgtm

[azani, 2016-03-23 23:08:46]

lgtm

lgtm

[rudominer, 2016-03-23 23:14:26]

lgtm

Can you elaborate on the situation that caused you to get the
`NoSuchMethodError: method not found: 'view_token_mojom'`.

If this is a bug in the Dart generator it is a serious bug we should fix.

[jeffbrown, 2016-03-23 23:15:23]

jeffbrown@google.com changed reviewers:
+ jeffbrown@google.com

[jeffbrown, 2016-03-23 23:15:23]

lgtm, definitely looks like a bug in mojom since it has no problem resolving
types from transitive imports (although maybe I am using it wrong?)

[tonyg, 2016-03-23 23:18:39]

On 2016/03/23 23:14:26, rudominer wrote:
> lgtm
> 
> Can you elaborate on the situation that caused you to get the
> `NoSuchMethodError: method not found: 'view_token_mojom'`.
> 
> If this is a bug in the Dart generator it is a serious bug we should fix.

The generated ViewProviderCreateViewParams does this:
```
      result.viewOwner = decoder0.decodeInterfaceRequest(8, false,
view_token_mojom.ViewOwnerStub.newFromEndpoint);
```

That treats "view_token_mojom" as a member or local variable. My changes adds:

```
import 'package:mojo_services/mojo/ui/view_token.mojom.dart' as
view_token_mojom;

```
So that it is properly treated as a package.

ViewOwner was moved from views.mojom (which is directly imported) to
view_token.mojom (which prior to this patch was imported only by views.mojom).
This patch makes a transitive dependency explicit. Since this worked w/ the C++
bindings for flutter, my guess is that C++ bindings respect transitive deps, but
dart bindings don't.

[tonyg, 2016-03-23 23:20:39]

Description was changed from

==========
Fix generated dart bindings for view_provider.

Previously:
`NoSuchMethodError: method not found: 'view_token_mojom'`

There's probably a bug in the dart bindings generator that imports of
views.mojom aren't made available here.

BUG=
==========

to

==========
Fix generated dart bindings for view_provider.

Previously:
`NoSuchMethodError: method not found: 'view_token_mojom'`

There's probably a bug in the dart bindings generator that imports of
views.mojom aren't made available here.

BUG=
R=azani@chromium.org, jeffbrown@google.com, rudominer@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/31c5037ab2c63649632c9f2d422...
==========

[tonyg, 2016-03-23 23:20:41]

Committed patchset #2 (id:20001) manually as
31c5037ab2c63649632c9f2d4227ebe6f22015a4 (presubmit successful).

[rudominer, 2016-03-23 23:21:26]

On 2016/03/23 23:18:39, tonyg wrote:
> On 2016/03/23 23:14:26, rudominer wrote:
> > lgtm
> > 
> > Can you elaborate on the situation that caused you to get the
> > `NoSuchMethodError: method not found: 'view_token_mojom'`.
> > 
> > If this is a bug in the Dart generator it is a serious bug we should fix.
> 
> The generated ViewProviderCreateViewParams does this:
> ```
>       result.viewOwner = decoder0.decodeInterfaceRequest(8, false,
> view_token_mojom.ViewOwnerStub.newFromEndpoint);
> ```
> 
> That treats "view_token_mojom" as a member or local variable. My changes adds:
> 
> ```
> import 'package:mojo_services/mojo/ui/view_token.mojom.dart' as
> view_token_mojom;
> 
> ```
> So that it is properly treated as a package.
> 
> ViewOwner was moved from views.mojom (which is directly imported) to
> view_token.mojom (which prior to this patch was imported only by views.mojom).
> This patch makes a transitive dependency explicit. Since this worked w/ the
C++
> bindings for flutter, my guess is that C++ bindings respect transitive deps,
but
> dart bindings don't.

The Dart bindings definitely are supposed to handle transitive imports. We think
there is a bug that Alex is looking into.