Issue 1834513002: Avoid useless allocations in _CompactLinkedHashSet constructor

Issue 1834513002: Avoid useless allocations in _CompactLinkedHashSet constructor (Closed)

Created:
4 years, 9 months ago by sra1

Modified:
4 years, 9 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -11 lines)			Patch
	M	runtime/lib/compact_hash.dart	View	1	9 chunks	+22 lines, -11 lines	0 comments	Download

Total messages: 7 (4 generated)

hausner

LGTM. It's probably cleaner not to allocate in an abstract base class anyway.

4 years, 9 months ago (2016-03-23 23:54:29 UTC) #5

sra1

4 years, 9 months ago (2016-03-24 00:00:00 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
20c2ece316721dc958437d3a3050f8afd815bc21 (presubmit successful).