Allow Subzero to parse function blocks in parallel.

src/IceTranslator.cpp

 //===- subzero/src/IceTranslator.cpp - ICE to machine code ------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
 /// \brief Defines the general driver class for translating ICE to machine code.
 ///
 //===----------------------------------------------------------------------===//
 
 #include "IceTranslator.h"
 
 #include "IceDefs.h"
 #include "IceCfg.h"
 #include "IceClFlags.h"
 #include "IceGlobalInits.h"
 #include "IceTargetLowering.h"
 
 #include <utility>
 
+namespace {

[John, 2016/03/24 17:32:35]

enclose this namespace in Ice, and then remove the Ice:: references.

[Karl, 2016/03/24 22:35:25]

Done.

+
+class CfgOptWorkItem : public Ice::OptWorkItem {
+  CfgOptWorkItem() = delete;
+  CfgOptWorkItem(const CfgOptWorkItem &) = delete;
+  CfgOptWorkItem &operator=(const CfgOptWorkItem &) = delete;
+
+public:
+  CfgOptWorkItem(std::unique_ptr<Ice::Cfg> Func) : Func(std::move(Func)) {}
+  std::unique_ptr<Ice::Cfg> getParsedCfg() final { return std::move(Func); }

[John, 2016/03/24 17:32:34]

final is better off when used in the class declaration, i.e.,

class CfgOptWorkItem final : public OptWOrkItem {};

then these "final" become "override"

+  ~CfgOptWorkItem() final {}

[John, 2016/03/24 17:32:35]

~CfgOptWorkItem() override = default;

[Karl, 2016/03/24 22:35:25]

Done.

+
+private:
+  std::unique_ptr<Ice::Cfg> Func;
+};
+
+} // end of anonymous namespace
+
 namespace Ice {
 
 Translator::Translator(GlobalContext *Ctx)
     : Ctx(Ctx), NextSequenceNumber(GlobalContext::getFirstSequenceNumber()),
       ErrorStatus() {}
 
 IceString Translator::createUnnamedName(const IceString &Prefix, SizeT Index) {
   if (Index == 0)
     return Prefix;
   std::string Buffer;
@@ skipping 13 matching lines @@
     OstreamLocker L(Ctx);
     Ostream &Stream = Ctx->getStrDump();
     Stream << "Warning : Default " << Kind << " prefix '" << Prefix
            << "' potentially conflicts with name '" << Name << "'.\n";
     return true;
   }
   return false;
 }
 
 void Translator::translateFcn(std::unique_ptr<Cfg> Func) {
-  Ctx->optQueueBlockingPush(std::move(Func));
+  Ctx->optQueueBlockingPush(makeUnique<CfgOptWorkItem>(std::move(Func)));
 }
 
 void Translator::lowerGlobals(
     std::unique_ptr<VariableDeclarationList> VariableDeclarations) {
   Ctx->emitQueueBlockingPush(makeUnique<EmitterWorkItem>(
       getNextSequenceNumber(), std::move(VariableDeclarations)));
 }
 
 } // end of namespace Ice