Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3376)

Unified Diff: chrome/chrome_watcher/chrome_watcher_main.cc

Issue 1834463002: Identify the hung thread using the Wait Chain Traversal API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: BASE_EXPORT Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/process_singleton_win.cc ('k') | chrome/chrome_watcher/kasko_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_watcher/chrome_watcher_main.cc
diff --git a/chrome/chrome_watcher/chrome_watcher_main.cc b/chrome/chrome_watcher/chrome_watcher_main.cc
index 95ead7765eb414e75cccb197379dcd42485d7e81..8e0007945cb7b157c66dcf90abacd2bd4210f520 100644
--- a/chrome/chrome_watcher/chrome_watcher_main.cc
+++ b/chrome/chrome_watcher/chrome_watcher_main.cc
@@ -224,11 +224,9 @@ extern "C" int WatcherMain(const base::char16* registry_path,
browser_data_directory);
#if BUILDFLAG(ENABLE_KASKO_HANG_REPORTS)
- // Only activate hang reports for the canary channel. For testing purposes,
- // Chrome instances with no channels will also report hangs.
+ // Only activate hang reports for the canary channel.
if (launched_kasko &&
- (base::StringPiece16(channel_name) == L"" ||
- base::StringPiece16(channel_name) == installer::kChromeChannelCanary)) {
+ base::StringPiece16(channel_name) == installer::kChromeChannelCanary) {
on_hung_callback = base::Bind(&DumpHungProcess, main_thread_id,
channel_name, L"hung-process");
}
« no previous file with comments | « chrome/browser/process_singleton_win.cc ('k') | chrome/chrome_watcher/kasko_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698