Issue 1834423002: Sort the files in analysis_server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1834423002: Sort the files in analysis_server (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson

Modified:
4 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Sort the files in analysis_server R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/338c95be8caa988f6e131a5da84f5f949a1b1292

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1676 lines, -1673 lines)			Patch
M	pkg/analysis_server/benchmark/integration/instrumentation_input_converter.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/benchmark/integration/local_runner.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/benchmark/integration/log_file_input_converter.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/benchmark/perf/completion_timing_tests.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/benchmark/perf/performance_tests.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/computer/computer_overrides.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/constants.dart	View	3 chunks	+66 lines, -66 lines	0 comments	Download
M	pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart	View	2 chunks	+26 lines, -26 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart	View	2 chunks	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/assist.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/organize_directives.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/extract_local.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/domain_completion_test.dart	View	2 chunks	+41 lines, -41 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart	View	5 chunks	+44 lines, -44 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/inherited_reference_contributor_test.dart	View	2 chunks	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/library_member_contributor_test.dart	View	2 chunks	+15 lines, -15 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart	View	14 chunks	+344 lines, -344 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/local_library_contributor_test.dart	View	5 chunks	+34 lines, -34 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart	View	15 chunks	+390 lines, -390 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/static_member_contributor_test.dart	View	2 chunks	+47 lines, -47 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/test_all.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/type_member_contributor_test.dart	View	10 chunks	+640 lines, -640 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

4 years, 8 months ago (2016-03-29 01:25:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
338c95be8caa988f6e131a5da84f5f949a1b1292 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages