Fast-fail to catch VC++ compiler crashes

Fast-fail to catch VC++ compiler crashes

The VC++ compiler and linker default to catching their crashes using
structure exception handling. They then print out a helpful message.
This helpful message is rarely enough information to let us diagnose
what went wrong. crrev.com/1816333002 added /fastfail to the linker
command line and this adds /d2FastFail to the compiler command line,
for gyp and gn.

These options are undocumented and unsupported but very handy -
the linker /fastfail option was crucial in tracking down a linker
crash.

Committed: https://crrev.com/10b66c067178bfcfb89b20627f9bb4779ac2efeb
Cr-Commit-Position: refs/heads/master@{#383765}

[brucedawson, 2016-03-29 02:03:16]

brucedawson@chromium.org changed reviewers:
+ scottmg@chromium.org

[brucedawson, 2016-03-29 02:03:17]

Go fast fail!

Goma got updated to handle this (try jobs are passing).

With the linker /fastfail switch I added it to the wrong place for .gn and then
moved it. This time I'm adding it to the correct place right away.

[scottmg, 2016-03-29 17:45:37]

lgtm

[brucedawson, 2016-03-29 17:50:12]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-03-29 17:50:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834413002/1

[commit-bot: I haz the power, 2016-03-29 17:56:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-29 17:57:41]

Description was changed from

==========
Fast-fail to catch VC++ compiler crashes

The VC++ compiler and linker default to catching their crashes using
structure exception handling. They then print out a helpful message.
This helpful message is rarely enough information to let us diagnose
what went wrong. crrev.com/1816333002 added /fastfail to the linker
command line and this adds /d2FastFail to the compiler command line,
for gyp and gn.

These options are undocumented and unsupported but very handy -
the linker /fastfail option was crucial in tracking down a linker
crash.
==========

to

==========
Fast-fail to catch VC++ compiler crashes

The VC++ compiler and linker default to catching their crashes using
structure exception handling. They then print out a helpful message.
This helpful message is rarely enough information to let us diagnose
what went wrong. crrev.com/1816333002 added /fastfail to the linker
command line and this adds /d2FastFail to the compiler command line,
for gyp and gn.

These options are undocumented and unsupported but very handy -
the linker /fastfail option was crucial in tracking down a linker
crash.

Committed: https://crrev.com/10b66c067178bfcfb89b20627f9bb4779ac2efeb
Cr-Commit-Position: refs/heads/master@{#383765}
==========

[commit-bot: I haz the power, 2016-03-29 17:57:42]

Patchset 1 (id:??) landed as
https://crrev.com/10b66c067178bfcfb89b20627f9bb4779ac2efeb
Cr-Commit-Position: refs/heads/master@{#383765}

[Nico, 2016-03-29 20:26:06]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1843783002/ by thakis@chromium.org.

The reason for reverting is: clang-cl complains about not understanding
/d2FastFail. I added it upstream, but we need to roll that in first (or add
!is_clang checks here in the meantime if it's important to have this CL in. The
description sounds like it could wait a while, though.).