Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4652)

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 18344010: Completing high dpi support for Instant Extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync and rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/searchbox/searchbox.cc ('k') | chrome/renderer/searchbox/searchbox_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/searchbox/searchbox_extension.cc
diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc
index 4beae50b6021922256dbb972793cd60bb2c0be7f..7a1267bfbf73405f1d59a4ab1426493f40d7e61f 100644
--- a/chrome/renderer/searchbox/searchbox_extension.cc
+++ b/chrome/renderer/searchbox/searchbox_extension.cc
@@ -80,14 +80,6 @@ v8::Handle<v8::String> GenerateThumbnailURL(
most_visited_item_id));
}
-v8::Handle<v8::String> GenerateFaviconURL(
- int render_view_id,
- InstantRestrictedID most_visited_item_id) {
- return UTF8ToV8String(base::StringPrintf("chrome-search://favicon/%d/%d",
- render_view_id,
- most_visited_item_id));
-}
-
// Populates a Javascript MostVisitedItem object from |mv_item|.
// NOTE: Includes "url", "title" and "domain" which are private data, so should
// not be returned to the Instant page. These should be erased before returning
@@ -118,11 +110,10 @@ v8::Handle<v8::Object> GenerateMostVisitedItem(
title = UTF8ToUTF16(mv_item.url.spec());
v8::Handle<v8::Object> obj = v8::Object::New();
+ obj->Set(v8::String::New("renderViewId"), v8::Int32::New(render_view_id));
obj->Set(v8::String::New("rid"), v8::Int32::New(restricted_id));
obj->Set(v8::String::New("thumbnailUrl"),
GenerateThumbnailURL(render_view_id, restricted_id));
- obj->Set(v8::String::New("faviconUrl"),
- GenerateFaviconURL(render_view_id, restricted_id));
obj->Set(v8::String::New("title"), UTF16ToV8String(title));
obj->Set(v8::String::New("domain"), UTF8ToV8String(mv_item.url.host()));
obj->Set(v8::String::New("direction"), UTF8ToV8String(direction));
« no previous file with comments | « chrome/renderer/searchbox/searchbox.cc ('k') | chrome/renderer/searchbox/searchbox_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698