Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 18344005: DevTools: expose setLayerTreeId() so we can relate events from LayerTreeHost (Closed)

Created:
7 years, 5 months ago by caseq
Modified:
7 years, 5 months ago
Reviewers:
vsevik, apavlov, pfeldman, jamesr
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: expose setLayerTreeId() so we can relate events from LayerTreeHost Currently, we track which content layers are painted in WebCore to track layers that belong to a page. This is a hack and does not work for non-content layers, so let's bind layer tree to a page and updated layers to layer tree. R=apavlov@chromium.org, jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153787 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154007

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed appcache test failures, trying on bots... #

Patch Set 3 : rebased #

Patch Set 4 : fixed another regression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -18 lines) Patch
M Source/core/inspector/InspectorController.h View 2 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 2 2 chunks +10 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorInstrumentation.cpp View 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/TimelineTraceEventProcessor.h View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M Source/core/inspector/TimelineTraceEventProcessor.cpp View 1 2 3 2 chunks +31 lines, -9 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebDevToolsAgent.h View 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
caseq
This is extracted from https://codereview.chromium.org/16878004/. We don't want to instrument deferred canvas the way we ...
7 years, 5 months ago (2013-07-01 13:37:27 UTC) #1
caseq
ping
7 years, 5 months ago (2013-07-03 10:25:30 UTC) #2
apavlov
LGTM with a comment https://codereview.chromium.org/18344005/diff/1/Source/core/inspector/InspectorTimelineAgent.h File Source/core/inspector/InspectorTimelineAgent.h (right): https://codereview.chromium.org/18344005/diff/1/Source/core/inspector/InspectorTimelineAgent.h#newcode124 Source/core/inspector/InspectorTimelineAgent.h:124: void setLayerTreeId(int layerTreeId) { m_layerTreeId ...
7 years, 5 months ago (2013-07-03 11:48:53 UTC) #3
caseq
On 2013/07/03 11:48:53, apavlov wrote: > > https://codereview.chromium.org/18344005/diff/1/Source/core/inspector/InspectorTimelineAgent.h#newcode124 > Source/core/inspector/InspectorTimelineAgent.h:124: void setLayerTreeId(int > layerTreeId) { ...
7 years, 5 months ago (2013-07-04 09:33:04 UTC) #4
caseq
+jamesr for public OWNERS. James, could you please have a look?
7 years, 5 months ago (2013-07-04 10:18:34 UTC) #5
jamesr
lgtm
7 years, 5 months ago (2013-07-09 01:58:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/18344005/1
7 years, 5 months ago (2013-07-09 09:05:34 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-09 09:26:26 UTC) #8
caseq
Committed patchset #1 manually as r153787 (presubmit successful).
7 years, 5 months ago (2013-07-09 14:35:37 UTC) #9
caseq
7 years, 5 months ago (2013-07-11 14:05:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 manually as r154007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698