Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: src/heap/heap-inl.h

Issue 1834373003: [heap] Add optimized RecordWrites (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: adressing comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/heap/heap.cc ('K') | « src/heap/heap.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap-inl.h
diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h
index 7b2f5ead9b9a3ff53617f12212ebdfe253f99eac..df9072e78020dc07f3658f4a50ff1febb4b7d049 100644
--- a/src/heap/heap-inl.h
+++ b/src/heap/heap-inl.h
@@ -399,9 +399,20 @@ void Heap::RecordWrite(Object* object, int offset, Object* o) {
if (!InNewSpace(o) || !object->IsHeapObject() || InNewSpace(object)) {
return;
}
- Page* page = Page::FromAddress(reinterpret_cast<Address>(object));
- Address slot = HeapObject::cast(object)->address() + offset;
- RememberedSet<OLD_TO_NEW>::Insert(page, slot);
+ RememberedSet<OLD_TO_NEW>::Insert(
+ Page::FromAddress(reinterpret_cast<Address>(object)),
+ HeapObject::cast(object)->address() + offset);
+}
+
+void Heap::RecordFixedArrayElements(FixedArray* array, int offset, int length) {
+ if (InNewSpace(array)) return;
+ Page* page = Page::FromAddress(reinterpret_cast<Address>(array));
+ for (int i = 0; i < length; i++) {
+ if (!InNewSpace(array->get(i))) continue;
ulan 2016/04/11 12:49:23 This should be if (!InNewSpace(array->get(offset +
+ RememberedSet<OLD_TO_NEW>::Insert(
+ page,
+ reinterpret_cast<Address>(array->RawFieldOfElementAt(offset + i)));
+ }
}
« src/heap/heap.cc ('K') | « src/heap/heap.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698