Override DRP proxies from command line switches

Override DRP proxies from command line switches

If "spdy-proxy-dev-auth-origin" or
"spdy-proxy-auth-fallback" switch is specified on the
command line, then DRP proxies are overriden even if
Chromium is using client config service.

This change is required to preserve the functionality of
these switches after Chromium permanently moves to
the client config service.

BUG=597768
Committed: https://crrev.com/d6dc2f61bde358880132c898dc99dd995d9b7103
Cr-Commit-Position: refs/heads/master@{#383648}

[tbansal1, 2016-03-28 23:06:16]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-03-28 23:08:01]

Description was changed from

==========
w


w


w


w

w

w

w

w

w

BUG=
==========

to

==========
Override DRP proxies from command line switches

If "spdy-proxy-dev-auth-origin" or
"spdy-proxy-auth-fallback" switch is specified on the
command line, then DRP proxies are overriden even if
Chromium is using client config service.

BUG=597768
==========

[tbansal1, 2016-03-28 23:09:14]

Description was changed from

==========
Override DRP proxies from command line switches

If "spdy-proxy-dev-auth-origin" or
"spdy-proxy-auth-fallback" switch is specified on the
command line, then DRP proxies are overriden even if
Chromium is using client config service.

BUG=597768
==========

to

==========
Override DRP proxies from command line switches

If "spdy-proxy-dev-auth-origin" or
"spdy-proxy-auth-fallback" switch is specified on the
command line, then DRP proxies are overriden even if
Chromium is using client config service.

This change is required to preserve the functionality of 
these switches after Chromium permanently moves to 
the client config service.

BUG=597768
==========

[tbansal1, 2016-03-28 23:09:30]

tbansal@chromium.org changed reviewers:
+ sclittle@chromium.org

[tbansal1, 2016-03-28 23:09:31]

sclittle: ptal. thanks!!

[sclittle, 2016-03-28 23:29:14]

LGTM % nit

https://codereview.chromium.org/1834373002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/1834373002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:267:
// It is illegal to use |kDataReductionProxy| or
Could you document this in drp_switches.cc as well?

[tbansal1, 2016-03-29 00:30:22]

Patchset #2 (id:40001) has been deleted

[tbansal1, 2016-03-29 00:30:41]

https://codereview.chromium.org/1834373002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/1834373002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:267:
// It is illegal to use |kDataReductionProxy| or
On 2016/03/28 23:29:14, sclittle wrote:
> Could you document this in drp_switches.cc as well?

Done.

[tbansal1, 2016-03-29 00:30:44]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-03-29 00:30:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/1834373002/#ps60001
(title: "Addressed sclittle comment")

[commit-bot: I haz the power, 2016-03-29 00:30:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834373002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834373002/60001

[commit-bot: I haz the power, 2016-03-29 01:30:09]

Description was changed from

==========
Override DRP proxies from command line switches

If "spdy-proxy-dev-auth-origin" or
"spdy-proxy-auth-fallback" switch is specified on the
command line, then DRP proxies are overriden even if
Chromium is using client config service.

This change is required to preserve the functionality of 
these switches after Chromium permanently moves to 
the client config service.

BUG=597768
==========

to

==========
Override DRP proxies from command line switches

If "spdy-proxy-dev-auth-origin" or
"spdy-proxy-auth-fallback" switch is specified on the
command line, then DRP proxies are overriden even if
Chromium is using client config service.

This change is required to preserve the functionality of 
these switches after Chromium permanently moves to 
the client config service.

BUG=597768
==========

[commit-bot: I haz the power, 2016-03-29 01:30:10]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-03-29 01:31:39]

Description was changed from

==========
Override DRP proxies from command line switches

If "spdy-proxy-dev-auth-origin" or
"spdy-proxy-auth-fallback" switch is specified on the
command line, then DRP proxies are overriden even if
Chromium is using client config service.

This change is required to preserve the functionality of 
these switches after Chromium permanently moves to 
the client config service.

BUG=597768
==========

to

==========
Override DRP proxies from command line switches

If "spdy-proxy-dev-auth-origin" or
"spdy-proxy-auth-fallback" switch is specified on the
command line, then DRP proxies are overriden even if
Chromium is using client config service.

This change is required to preserve the functionality of
these switches after Chromium permanently moves to
the client config service.

BUG=597768

Committed: https://crrev.com/d6dc2f61bde358880132c898dc99dd995d9b7103
Cr-Commit-Position: refs/heads/master@{#383648}
==========

[commit-bot: I haz the power, 2016-03-29 01:31:40]

Patchset 2 (id:??) landed as
https://crrev.com/d6dc2f61bde358880132c898dc99dd995d9b7103
Cr-Commit-Position: refs/heads/master@{#383648}