Move xfa/include/fwl/{theme,lightwidget} to xfa/fwl

Move xfa/include/fwl/{theme,lightwidget} to xfa/fwl

This CL moves and splits the remaining FWL files out of xfa/include and into
their proper locations.

Committed: https://pdfium.googlesource.com/pdfium/+/7f432a1c87014d6673ee69ff0ffa3724f237acf4

[dsinclair, 2016-03-29 14:39:52]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-03-29 14:39:53]

PTAL.

[Tom Sepez, 2016-03-29 16:45:32]

lgtm

https://codereview.chromium.org/1834323003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1834323003/diff/20001/BUILD.gn#newcode1138
BUILD.gn:1138: "xfa/fwl/theme/cfwl_utils.h",
Is there a corresponding .cpp file for utils?

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_app.cpp (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_app.cpp:20: m_pTheme = NULL;
nit: nulling it out not needed.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_widgetdelegate.h (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widgetdelegate.h:17: class CFWL_WidgetDelegate {
Does this inherit/override from ifwl_widgetdelegate?

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_widgetproperties.h (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widgetproperties.h:21: m_ctmOnParent.SetIdentity();
nit: The default ctor for CFX_Matrix already does this.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widgetproperties.h:22: m_rtWidget.Set(0, 0, 0, 0);
Pity the default ctor doesn't do this ...

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widgetproperties.h:23: m_dwStyles = FWL_WGTSTYLE_Child;
nit: initializer list

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widgetproperties.h:26: m_pParent = NULL;
nit: nullptr

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_date...
File xfa/fwl/theme/cfwl_datetimepickedtp.cpp (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_date...
xfa/fwl/theme/cfwl_datetimepickedtp.cpp:115: *pData++ = 0, *pData++ = 0,
*pData++ = ArgbEncode(255, 220, 220, 215),
nit: semicolons.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_push...
File xfa/fwl/theme/cfwl_pushbuttontp.h (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_push...
xfa/fwl/theme/cfwl_pushbuttontp.h:36: struct PBThemeData {
nit: maybe separate struct declaration from member declaration, eg. struct at
line 26, PBThemeData* m_pThemeData; at line 41

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_scro...
File xfa/fwl/theme/cfwl_scrollbartp.h (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_scro...
xfa/fwl/theme/cfwl_scrollbartp.h:53: FX_ARGB clrTrackBKEnd;
same here.

[dsinclair, 2016-03-29 19:22:24]

https://codereview.chromium.org/1834323003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1834323003/diff/20001/BUILD.gn#newcode1138
BUILD.gn:1138: "xfa/fwl/theme/cfwl_utils.h",
On 2016/03/29 16:45:31, Tom Sepez wrote:
> Is there a corresponding .cpp file for utils?

Nope, it's all defines and declarations.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_app.cpp (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_app.cpp:20: m_pTheme = NULL;
On 2016/03/29 16:45:31, Tom Sepez wrote:
> nit: nulling it out not needed.

Done.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_widgetdelegate.h (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widgetdelegate.h:17: class CFWL_WidgetDelegate {
On 2016/03/29 16:45:31, Tom Sepez wrote:
> Does this inherit/override from ifwl_widgetdelegate?

Looks like it should, fixed.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_widgetproperties.h (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widgetproperties.h:21: m_ctmOnParent.SetIdentity();
On 2016/03/29 16:45:31, Tom Sepez wrote:
> nit: The default ctor for CFX_Matrix already does this.

Done.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widgetproperties.h:22: m_rtWidget.Set(0, 0, 0, 0);
On 2016/03/29 16:45:31, Tom Sepez wrote:
> Pity the default ctor doesn't do this ...

CFX_RectF is an instantiation of a CFX_Remplate<FX_FLOAT> so the ctor doesn't
know the type to set I'd guess.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widgetproperties.h:23: m_dwStyles = FWL_WGTSTYLE_Child;
On 2016/03/29 16:45:31, Tom Sepez wrote:
> nit: initializer list

Done.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widgetproperties.h:26: m_pParent = NULL;
On 2016/03/29 16:45:31, Tom Sepez wrote:
> nit: nullptr

Done.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_date...
File xfa/fwl/theme/cfwl_datetimepickedtp.cpp (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_date...
xfa/fwl/theme/cfwl_datetimepickedtp.cpp:115: *pData++ = 0, *pData++ = 0,
*pData++ = ArgbEncode(255, 220, 220, 215),
On 2016/03/29 16:45:31, Tom Sepez wrote:
> nit: semicolons.

Done.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_push...
File xfa/fwl/theme/cfwl_pushbuttontp.h (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_push...
xfa/fwl/theme/cfwl_pushbuttontp.h:36: struct PBThemeData {
On 2016/03/29 16:45:31, Tom Sepez wrote:
> nit: maybe separate struct declaration from member declaration, eg. struct at
> line 26, PBThemeData* m_pThemeData; at line 41

Done.

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_scro...
File xfa/fwl/theme/cfwl_scrollbartp.h (right):

https://codereview.chromium.org/1834323003/diff/20001/xfa/fwl/theme/cfwl_scro...
xfa/fwl/theme/cfwl_scrollbartp.h:53: FX_ARGB clrTrackBKEnd;
On 2016/03/29 16:45:31, Tom Sepez wrote:
> same here.

Done.

[dsinclair, 2016-03-29 19:22:38]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-03-29 19:22:38]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1834323003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-29 19:22:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834323003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834323003/40001

[commit-bot: I haz the power, 2016-03-29 19:38:05]

Description was changed from

==========
Move xfa/include/fwl/{theme,lightwidget} to xfa/fwl

This CL moves and splits the remaining FWL files out of xfa/include and into
their proper locations.
==========

to

==========
Move xfa/include/fwl/{theme,lightwidget} to xfa/fwl

This CL moves and splits the remaining FWL files out of xfa/include and into
their proper locations.

Committed:
https://pdfium.googlesource.com/pdfium/+/7f432a1c87014d6673ee69ff0ffa3724f237...
==========

[commit-bot: I haz the power, 2016-03-29 19:38:07]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/7f432a1c87014d6673ee69ff0ffa3724f237...

[Tom Sepez, 2016-03-29 21:24:44]

https://codereview.chromium.org/1834323003/diff/40001/xfa/fwl/theme/cfwl_date...
File xfa/fwl/theme/cfwl_datetimepickedtp.cpp (right):

https://codereview.chromium.org/1834323003/diff/40001/xfa/fwl/theme/cfwl_date...
xfa/fwl/theme/cfwl_datetimepickedtp.cpp:117: *pData++ = ArgbEncode(255, 220,
220, 215),
missed a few more :) ...

https://codereview.chromium.org/1834323003/diff/40001/xfa/fwl/theme/cfwl_push...
File xfa/fwl/theme/cfwl_pushbuttontp.h (right):

https://codereview.chromium.org/1834323003/diff/40001/xfa/fwl/theme/cfwl_push...
xfa/fwl/theme/cfwl_pushbuttontp.h:43: struct PBThemeData* m_pThemeData;
nit: "struct" not needed here.

https://codereview.chromium.org/1834323003/diff/40001/xfa/fwl/theme/cfwl_scro...
File xfa/fwl/theme/cfwl_scrollbartp.h (right):

https://codereview.chromium.org/1834323003/diff/40001/xfa/fwl/theme/cfwl_scro...
xfa/fwl/theme/cfwl_scrollbartp.h:57: struct SBThemeData* m_pThemeData;
ditto.