content/renderer/media/media_stream_audio_processor.cc - Issue 1834323002: MediaStream audio: Refactor 3 separate "glue" implementations into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_audio_processor.cc

Issue 1834323002: MediaStream audio: Refactor 3 separate "glue" implementations into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE + Workaround to ensure MediaStreamAudioProcessor is destroyed on the main thread. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/media_stream_audio_deliverer.h ('k') | content/renderer/media/media_stream_audio_processor_options.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_audio_processor.cc

diff --git a/content/renderer/media/media_stream_audio_processor.cc b/content/renderer/media/media_stream_audio_processor.cc

index b733857442a51d66f6f52f6326f9d7ca360d6cca..68aefcbff88663ebfba25ccac372b0aa999c0f54 100644

--- a/content/renderer/media/media_stream_audio_processor.cc

+++ b/content/renderer/media/media_stream_audio_processor.cc

@@ -302,6 +302,9 @@ MediaStreamAudioProcessor::MediaStreamAudioProcessor(

}

MediaStreamAudioProcessor::~MediaStreamAudioProcessor() {

+ // TODO(miu): This class is ref-counted, shared among threads, and then

+ // requires itself to be destroyed on the main thread only?!?!? Fix this, and

+ // then remove the hack in WebRtcAudioSink::Adapter.

DCHECK(main_thread_checker_.CalledOnValidThread());

Stop();

}