content/renderer/media/media_stream_center.h - Issue 1834323002: MediaStream audio: Refactor 3 separate "glue" implementations into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_center.h

Issue 1834323002: MediaStream audio: Refactor 3 separate "glue" implementations into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reworked unit tests around structural changes, and added exhaustive media_stream_audio_unittest.cc. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_unittest.cc ('K') | « content/renderer/media/media_stream_audio_unittest.cc ('k') | content/renderer/media/media_stream_center.cc » ('j') | content/renderer/media/mock_audio_device_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_center.h

diff --git a/content/renderer/media/media_stream_center.h b/content/renderer/media/media_stream_center.h

index 5b72e6cd2bae68a28cc6e1bb40cd7f9ae33169aa..8b58afd3f39f8b1ff2d4b63045bdb439e94ad4ef 100644

--- a/content/renderer/media/media_stream_center.h

+++ b/content/renderer/media/media_stream_center.h

@@ -27,6 +27,8 @@ class PeerConnectionDependencyFactory;

class CONTENT_EXPORT MediaStreamCenter

: NON_EXPORTED_BASE(public blink::WebMediaStreamCenter) {

public:

+ // TODO(miu): Remove these constructor args. They are no longer used.

+ // http://crbug.com/577874

MediaStreamCenter(blink::WebMediaStreamCenterClient* client,

PeerConnectionDependencyFactory* factory);

~MediaStreamCenter() override;

@@ -58,10 +60,6 @@ class CONTENT_EXPORT MediaStreamCenter

const blink::WebMediaStream& stream,

const blink::WebMediaStreamTrack& track) override;

- // |rtc_factory_| is a weak pointer and is owned by the RenderThreadImpl.

- // It is valid as long as RenderThreadImpl exist.

- PeerConnectionDependencyFactory* rtc_factory_;

DISALLOW_COPY_AND_ASSIGN(MediaStreamCenter);

};