content/renderer/media/media_stream_renderer_factory_impl.cc - Issue 1834323002: MediaStream audio: Refactor 3 separate "glue" implementations into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_renderer_factory_impl.cc

Issue 1834323002: MediaStream audio: Refactor 3 separate "glue" implementations into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unconditionally create MSAudioTrack; Remove hack in RtcPCHandler; One space after periods. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_source.cc ('K') | « content/renderer/media/media_stream_center.cc ('k') | content/renderer/media/media_stream_source.h » ('j') | content/renderer/media/webrtc/peer_connection_remote_audio_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_renderer_factory_impl.cc

diff --git a/content/renderer/media/media_stream_renderer_factory_impl.cc b/content/renderer/media/media_stream_renderer_factory_impl.cc

index 2bd9799bb0c6dc1fabe38e2b498e56f2698864cb..78cd37500f0c190a6848568f6dbfcf2fbae42276 100644

--- a/content/renderer/media/media_stream_renderer_factory_impl.cc

+++ b/content/renderer/media/media_stream_renderer_factory_impl.cc

@@ -11,6 +11,7 @@

#include "content/renderer/media/media_stream_video_track.h"

#include "content/renderer/media/track_audio_renderer.h"

#include "content/renderer/media/webrtc/peer_connection_dependency_factory.h"

+#include "content/renderer/media/webrtc/peer_connection_remote_audio_source.h"

#include "content/renderer/media/webrtc_audio_renderer.h"

#include "content/renderer/render_thread_impl.h"

#include "media/base/audio_hardware_config.h"

@@ -114,11 +115,7 @@ MediaStreamRendererFactoryImpl::GetAudioRenderer(

// If the track has a local source, or is a remote track that does not use the

// WebRTC audio pipeline, return a new TrackAudioRenderer instance.

- //

- // TODO(miu): In a soon up-coming change, I'll introduce a cleaner way (i.e.,

- // rather than calling GetAudioAdapter()) to determine whether a remote source

- // is via WebRTC or something else.

- if (audio_track->is_local_track() || !audio_track->GetAudioAdapter()) {

+ if (!PeerConnectionRemoteAudioTrack::From(audio_track)) {

// TODO(xians): Add support for the case where the media stream contains

// multiple audio tracks.

DVLOG(1) << "Creating TrackAudioRenderer for "