Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: media/base/audio_decoder.h

Issue 1834303005: Refactor audio and video decoder status into common file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix cast. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_decoder.h
diff --git a/media/base/audio_decoder.h b/media/base/audio_decoder.h
index 5c6efd6c5ce76a6b80a1d7fbbe969927537aec66..3c2371d13d89811c7113edccdfee86bdfb9a46b7 100644
--- a/media/base/audio_decoder.h
+++ b/media/base/audio_decoder.h
@@ -13,6 +13,7 @@
#include "media/base/audio_decoder_config.h"
#include "media/base/channel_layout.h"
#include "media/base/decoder_buffer.h"
+#include "media/base/decoder_status.h"
#include "media/base/media_export.h"
#include "media/base/pipeline_status.h"
@@ -24,15 +25,6 @@ class DemuxerStream;
class MEDIA_EXPORT AudioDecoder {
public:
- // Status codes for decode operations.
- // TODO(rileya): Now that both AudioDecoder and VideoDecoder Status enums
- // match, break them into a decoder_status.h.
- enum Status {
- kOk, // We're all good.
- kAborted, // We aborted as a result of Reset() or destruction.
- kDecodeError // A decoding error occurred.
- };
-
// Callback for VideoDecoder initialization.
typedef base::Callback<void(bool success)> InitCB;
@@ -42,7 +34,7 @@ class MEDIA_EXPORT AudioDecoder {
// Callback for Decode(). Called after the decoder has accepted corresponding
// DecoderBuffer, indicating that the pipeline can send next buffer to decode.
- typedef base::Callback<void(Status)> DecodeCB;
+ typedef base::Callback<void(DecoderStatus)> DecodeCB;
AudioDecoder();

Powered by Google App Engine
This is Rietveld 408576698