media/base/decoder_status.h - Issue 1834303005: Refactor audio and video decoder status into common file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/decoder_status.h

Issue 1834303005: Refactor audio and video decoder status into common file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix cast. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MEDIA_BASE_DECODER_STATUS_H_

	6 #define MEDIA_BASE_DECODER_STATUS_H_

	7

	8 #include <ostream>
	xhwang 2016/03/29 19:42:28 Will "#include <iosfwd>" work? See example: https Will "#include <iosfwd>" work? See example: https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/strin... DaleCurtis 2016/03/30 00:34:19 Done. Show quoted text On 2016/03/29 at 19:42:28, xhwang wrote: > Will "#include <iosfwd>" work? > > See example: https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/strin... Done.
	9

	10 #include "media/base/media_export.h"

	11

	12 namespace media {

	13

	14 enum class DecoderStatus {
	xhwang 2016/03/29 19:42:28 Since this the status of the "decode" operation, n Since this the status of the "decode" operation, not the general state/status of the "decoder". Should it be named "DecodeStatus"? Note that in mojo we actually use interfaces::AudioDecoder::DecodeStatus. DaleCurtis 2016/03/30 00:34:19 Renamed to DecodeStatus. Show quoted text On 2016/03/29 at 19:42:28, xhwang wrote: > Since this the status of the "decode" operation, not the general state/status of the "decoder". Should it be named "DecodeStatus"? > > Note that in mojo we actually use interfaces::AudioDecoder::DecodeStatus. Renamed to DecodeStatus.
	15 OK = 0, // Everything went as planned.

	16 ABORTED, // Read aborted due to Reset() during pending read.

	17 DECODE_ERROR, // Decoder returned decode error.
	xhwang 2016/03/29 19:42:28 The "DECODE" part seems redundant but apparently " The "DECODE" part seems redundant but apparently "ERROR" is defined as a special macro on Windows. Shall we document it so people won't ask again? Well, it won't look redundant when you add other error types. So totally up to you :) DaleCurtis 2016/03/30 00:34:19 Done. Show quoted text On 2016/03/29 at 19:42:28, xhwang wrote: > The "DECODE" part seems redundant but apparently "ERROR" is defined as a special macro on Windows. Shall we document it so people won't ask again? > > Well, it won't look redundant when you add other error types. So totally up to you :) Done.
	18 };

	19

	20 // Helper function so that DecoderStatus can be printed easily.

	21 MEDIA_EXPORT std::ostream& operator<<(std::ostream& os,

	22 const DecoderStatus& status);

	23

	24 } // namespace media

	25

	26 #endif // MEDIA_BASE_DECODER_STATUS_H_

OLD	NEW

« content/renderer/pepper/video_decoder_shim.cc ('K') | « media/base/audio_decoder.h ('k') | media/base/decoder_status.cc » ('j') | media/filters/decoder_stream.h » ('J')