Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1834293003: [Extensions UI] Tweak the constants for extension action grayscaling (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI] Tweak the constants for extension action grayscaling The previous grayscaling wasn't enough for extension actions that were mostly black-and-white. Make it a little more noticable. Note that this is still a problem for extension actions that just happen to be gray by default as well as for a11y. :( See crbug.com/597657. BUG=597981 Committed: https://crrev.com/f51a8dcc39fba8b6ce644a54f1ff3814e255b03e Cr-Commit-Position: refs/heads/master@{#383578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/extensions/icon_with_badge_image_source.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
4 years, 8 months ago (2016-03-28 21:39:07 UTC) #2
asargent_no_longer_on_chrome
lgtm
4 years, 8 months ago (2016-03-28 22:00:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834293003/1
4 years, 8 months ago (2016-03-28 22:04:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 22:10:09 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 22:11:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f51a8dcc39fba8b6ce644a54f1ff3814e255b03e
Cr-Commit-Position: refs/heads/master@{#383578}

Powered by Google App Engine
This is Rietveld 408576698