Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: third_party/WebKit/Source/core/paint/PartPainter.cpp

Issue 1834263002: Round visual rects when crossing frame boundaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/paint/PartPainter.h" 5 #include "core/paint/PartPainter.h"
6 6
7 #include "core/layout/LayoutPart.h" 7 #include "core/layout/LayoutPart.h"
8 #include "core/paint/BoxPainter.h" 8 #include "core/paint/BoxPainter.h"
9 #include "core/paint/LayoutObjectDrawingRecorder.h" 9 #include "core/paint/LayoutObjectDrawingRecorder.h"
10 #include "core/paint/PaintInfo.h" 10 #include "core/paint/PaintInfo.h"
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 void PartPainter::paintContents(const PaintInfo& paintInfo, const LayoutPoint& p aintOffset) 98 void PartPainter::paintContents(const PaintInfo& paintInfo, const LayoutPoint& p aintOffset)
99 { 99 {
100 LayoutPoint adjustedPaintOffset = paintOffset + m_layoutPart.location(); 100 LayoutPoint adjustedPaintOffset = paintOffset + m_layoutPart.location();
101 101
102 Widget* widget = m_layoutPart.widget(); 102 Widget* widget = m_layoutPart.widget();
103 RELEASE_ASSERT(widget); 103 RELEASE_ASSERT(widget);
104 104
105 // Tell the widget to paint now. This is the only time the widget is allowed 105 // Tell the widget to paint now. This is the only time the widget is allowed
106 // to paint itself. That way it will composite properly with z-indexed layer s. 106 // to paint itself. That way it will composite properly with z-indexed layer s.
107 IntPoint widgetLocation = widget->frameRect().location(); 107 IntPoint widgetLocation = widget->frameRect().location();
108 IntPoint paintLocation(roundToInt(adjustedPaintOffset.x() + m_layoutPart.bor derLeft() + m_layoutPart.paddingLeft()), 108 IntPoint paintLocation(roundedIntPoint(adjustedPaintOffset + m_layoutPart.co ntentBoxOffset()));
109 roundToInt(adjustedPaintOffset.y() + m_layoutPart.borderTop() + m_layout Part.paddingTop()));
110 109
111 IntSize widgetPaintOffset = paintLocation - widgetLocation; 110 IntSize widgetPaintOffset = paintLocation - widgetLocation;
112 // When painting widgets into compositing layers, tx and ty are relative to the enclosing compositing layer, 111 // When painting widgets into compositing layers, tx and ty are relative to the enclosing compositing layer,
113 // not the root. In this case, shift the CTM and adjust the CullRect to be r oot-relative to fix plugin drawing. 112 // not the root. In this case, shift the CTM and adjust the CullRect to be r oot-relative to fix plugin drawing.
114 TransformRecorder transform(paintInfo.context, m_layoutPart, 113 TransformRecorder transform(paintInfo.context, m_layoutPart,
115 AffineTransform::translation(widgetPaintOffset.width(), widgetPaintOffse t.height())); 114 AffineTransform::translation(widgetPaintOffset.width(), widgetPaintOffse t.height()));
116 115
117 CullRect adjustedCullRect(paintInfo.cullRect(), -widgetPaintOffset); 116 CullRect adjustedCullRect(paintInfo.cullRect(), -widgetPaintOffset);
118 widget->paint(paintInfo.context, adjustedCullRect); 117 widget->paint(paintInfo.context, adjustedCullRect);
119 } 118 }
120 119
121 } // namespace blink 120 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698