Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1834223009: Revert of Ensure we don't leak ObjectProxy objects (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
raymes, piman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ensure we don't leak ObjectProxy objects (patchset #2 id:20001 of https://codereview.chromium.org/1839933002/ ) Reason for revert: Somewhat speculative; PPAPITest.Instance_LeakedObjectDestructors started falling on several bots with `Assertion failed: (false), function ~BadDestructorObject, file ../../ppapi/tests/test_instance_deprecated.cc, line 234.`. Examples: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/21858 https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/23233 https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19901 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/27197 Original issue's description: > Ensure we don't leak ObjectProxy objects > > Previously, if an instance was destroyed before a plugin object > had a chance to be destroyed, it would be leaked. Now we always attempt > to deallocate the object if the instance is destroyed prior to the object. > > BUG=594926 > > Committed: https://crrev.com/0868033af81c965c393c4ca6d9ac1fc81001f593 > Cr-Commit-Position: refs/heads/master@{#384148} TBR=piman@chromium.org,raymes@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594926 Committed: https://crrev.com/6e1fff1a66e259fe3e19d0e75e5d432faf51af8d Cr-Commit-Position: refs/heads/master@{#384184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/renderer/pepper/plugin_object.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of Ensure we don't leak ObjectProxy objects
4 years, 8 months ago (2016-03-31 01:51:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834223009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834223009/1
4 years, 8 months ago (2016-03-31 01:51:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 01:52:20 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 01:53:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e1fff1a66e259fe3e19d0e75e5d432faf51af8d
Cr-Commit-Position: refs/heads/master@{#384184}

Powered by Google App Engine
This is Rietveld 408576698