Chromium Code Reviews
DescriptionRevert of Ensure we don't leak ObjectProxy objects (patchset #2 id:20001 of https://codereview.chromium.org/1839933002/ )
Reason for revert:
Somewhat speculative; PPAPITest.Instance_LeakedObjectDestructors started falling on several bots with `Assertion failed: (false), function ~BadDestructorObject, file ../../ppapi/tests/test_instance_deprecated.cc, line 234.`.
Examples:
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/21858
https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/23233
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19901
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/27197
Original issue's description:
> Ensure we don't leak ObjectProxy objects
>
> Previously, if an instance was destroyed before a plugin object
> had a chance to be destroyed, it would be leaked. Now we always attempt
> to deallocate the object if the instance is destroyed prior to the object.
>
> BUG=594926
>
> Committed: https://crrev.com/0868033af81c965c393c4ca6d9ac1fc81001f593
> Cr-Commit-Position: refs/heads/master@{#384148}
TBR=piman@chromium.org,raymes@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594926
Committed: https://crrev.com/6e1fff1a66e259fe3e19d0e75e5d432faf51af8d
Cr-Commit-Position: refs/heads/master@{#384184}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||