third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h - Issue 1834223008: All ancestor multicols must have enough rows before laying out some inner multicol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

Issue 1834223008: All ancestor multicols must have enough rows before laying out some inner multicol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: No zoom in test. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/line-in-next-row-in-fourth-inner-multicol-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

index 6634b227dccb3810600477f9abda020a3f5de58b..c898d71336d9103ebd17aa4f0b9a5223038a2a43 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

@@ -215,7 +215,7 @@ public:

// If we've run out of columns in the last fragmentainer group (column row), we have to insert

// another fragmentainer group in order to hold more columns. This means that we're moving to

// the next outer column (in the enclosing fragmentation context).

- void appendNewFragmentainerGroupIfNeeded(LayoutUnit bottomOffsetInFlowThread);

+ void appendNewFragmentainerGroupIfNeeded(LayoutUnit offsetInFlowThread, PageBoundaryRule);

// Implementing FragmentationContext:

bool isFragmentainerLogicalHeightKnown() final;