All ancestor multicols must have enough rows before laying out some inner multicol.

All ancestor multicols must have enough rows before laying out some inner multicol.

We had code in place to insert new rows (and rows in enclosing fragmentation
contexts) when we ran out of space during layout, but we didn't make sure
initially that enough rows had been created, which would result in calculating
an incorrect column height and cause general confusion.

appendNewFragmentainerGroupIfNeeded() now needs to take a PageBoundaryRule
argument (since the new code in this CL deals with top offsets rather than
bottom offsets).

BUG=597058, 588364
Committed: https://crrev.com/526a8dca5b5462f16feb4d65c8a95176503526f5
Cr-Commit-Position: refs/heads/master@{#384800}

[mstensho (USE GERRIT), 2016-03-31 19:06:13]

Description was changed from

==========
All ancestor multicols must have enough rows before laying out some inner
multicol.

We had code in place to insert new rows (and rows in enclosing fragmentation
contexts) when we ran out of space during layout, but we didn't make sure
initially that enough rows had been created, which would result in calculating
an incorrect column height and cause general confusion.

appendNewFragmentainerGroupIfNeeded() now needs to take a PageBoundaryRule
argument (since the new code in this CL deals with top offsets rather than
bottom offsets).

BUG=597058
==========

to

==========
All ancestor multicols must have enough rows before laying out some inner
multicol.

We had code in place to insert new rows (and rows in enclosing fragmentation
contexts) when we ran out of space during layout, but we didn't make sure
initially that enough rows had been created, which would result in calculating
an incorrect column height and cause general confusion.

appendNewFragmentainerGroupIfNeeded() now needs to take a PageBoundaryRule
argument (since the new code in this CL deals with top offsets rather than
bottom offsets).

BUG=597058, 588364
==========

[mstensho (USE GERRIT), 2016-03-31 19:18:39]

mstensho@opera.com changed reviewers:
+ leviw@chromium.org

[mstensho (USE GERRIT), 2016-03-31 19:18:39]

If you like multicol and multicol in multicol, you're gonna LOVE this one,
'cause it's got multicol in multicol in multicol in multicol in multicol! :)

Looks like the Windows trybots are bluescreening at the moment, though.

[leviw_travelin_and_unemployed, 2016-04-01 20:37:01]

Whew.... I *think* I followed what's going on here, but there's so much multicol
happening it hurt my head a bit.

LGTM.

https://codereview.chromium.org/1834223008/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/multicol/5-levels-of-nesting-crash.html
(right):

https://codereview.chromium.org/1834223008/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/multicol/5-levels-of-nesting-crash.html:7:
<div style="zoom:0.1; columns:1;">
Zoooooooom!

Is this necessary? Why must we zooooooom?

[mstensho (USE GERRIT), 2016-04-01 21:30:43]

On 2016/04/01 20:37:01, leviw wrote:
> Whew.... I *think* I followed what's going on here, but there's so much
multicol
> happening it hurt my head a bit.

I know. It's insane. :-/

And sorry about the zoomage. Wasn't necessary. Now you should be able to see all
the BRs clearly without getting an additional headache. :)

https://codereview.chromium.org/1834223008/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/multicol/5-levels-of-nesting-crash.html
(right):

https://codereview.chromium.org/1834223008/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/multicol/5-levels-of-nesting-crash.html:7:
<div style="zoom:0.1; columns:1;">
On 2016/04/01 20:37:01, leviw wrote:
> Zoooooooom!
> 
> Is this necessary? Why must we zooooooom?

Woho! Got rid of it!

[mstensho (USE GERRIT), 2016-04-02 08:00:55]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-04-02 08:00:55]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1834223008/#ps40001
(title: "No zoom in test.")

[commit-bot: I haz the power, 2016-04-02 08:00:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834223008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834223008/40001

[commit-bot: I haz the power, 2016-04-02 08:45:37]

Description was changed from

==========
All ancestor multicols must have enough rows before laying out some inner
multicol.

We had code in place to insert new rows (and rows in enclosing fragmentation
contexts) when we ran out of space during layout, but we didn't make sure
initially that enough rows had been created, which would result in calculating
an incorrect column height and cause general confusion.

appendNewFragmentainerGroupIfNeeded() now needs to take a PageBoundaryRule
argument (since the new code in this CL deals with top offsets rather than
bottom offsets).

BUG=597058, 588364
==========

to

==========
All ancestor multicols must have enough rows before laying out some inner
multicol.

We had code in place to insert new rows (and rows in enclosing fragmentation
contexts) when we ran out of space during layout, but we didn't make sure
initially that enough rows had been created, which would result in calculating
an incorrect column height and cause general confusion.

appendNewFragmentainerGroupIfNeeded() now needs to take a PageBoundaryRule
argument (since the new code in this CL deals with top offsets rather than
bottom offsets).

BUG=597058, 588364
==========

[commit-bot: I haz the power, 2016-04-02 08:45:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-02 08:47:04]

Description was changed from

==========
All ancestor multicols must have enough rows before laying out some inner
multicol.

We had code in place to insert new rows (and rows in enclosing fragmentation
contexts) when we ran out of space during layout, but we didn't make sure
initially that enough rows had been created, which would result in calculating
an incorrect column height and cause general confusion.

appendNewFragmentainerGroupIfNeeded() now needs to take a PageBoundaryRule
argument (since the new code in this CL deals with top offsets rather than
bottom offsets).

BUG=597058, 588364
==========

to

==========
All ancestor multicols must have enough rows before laying out some inner
multicol.

We had code in place to insert new rows (and rows in enclosing fragmentation
contexts) when we ran out of space during layout, but we didn't make sure
initially that enough rows had been created, which would result in calculating
an incorrect column height and cause general confusion.

appendNewFragmentainerGroupIfNeeded() now needs to take a PageBoundaryRule
argument (since the new code in this CL deals with top offsets rather than
bottom offsets).

BUG=597058, 588364

Committed: https://crrev.com/526a8dca5b5462f16feb4d65c8a95176503526f5
Cr-Commit-Position: refs/heads/master@{#384800}
==========

[commit-bot: I haz the power, 2016-04-02 08:47:05]

Patchset 3 (id:??) landed as
https://crrev.com/526a8dca5b5462f16feb4d65c8a95176503526f5
Cr-Commit-Position: refs/heads/master@{#384800}