Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: fpdfsdk/javascript/app.h

Issue 1834203002: use std::vector in more places in JavaScript bindings code. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@util_printx
Patch Set: Nits. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/javascript/JS_Runtime.cpp ('k') | fpdfsdk/javascript/app.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/app.h
diff --git a/fpdfsdk/javascript/app.h b/fpdfsdk/javascript/app.h
index 764f73b2f7a434c0cd32d562d7bec2f4468e432b..c6cda555d90bb58bf4657f7c60e51f8f441911cb 100644
--- a/fpdfsdk/javascript/app.h
+++ b/fpdfsdk/javascript/app.h
@@ -7,6 +7,7 @@
#ifndef FPDFSDK_JAVASCRIPT_APP_H_
#define FPDFSDK_JAVASCRIPT_APP_H_
+#include <memory>
#include <vector>
#include "fpdfsdk/javascript/JS_Define.h"
@@ -40,7 +41,6 @@ class app : public CJS_EmbedObj {
app(CJS_Object* pJSObject);
~app() override;
- public:
FX_BOOL activeDocs(IJS_Context* cc,
CJS_PropValue& vp,
CFX_WideString& sError);
@@ -160,9 +160,11 @@ class app : public CJS_EmbedObj {
void TimerProc(CJS_Timer* pTimer) override;
void RunJsScript(CJS_Runtime* pRuntime, const CFX_WideString& wsScript);
+ void ClearTimerCommon(const CJS_Value& param);
+
bool m_bCalculate;
bool m_bRuntimeHighLight;
- CFX_ArrayTemplate<CJS_Timer*> m_aTimer;
+ std::vector<std::unique_ptr<CJS_Timer>> m_Timers;
};
class CJS_App : public CJS_Object {
« no previous file with comments | « fpdfsdk/javascript/JS_Runtime.cpp ('k') | fpdfsdk/javascript/app.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698