Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: fpdfsdk/javascript/JS_Runtime.h

Issue 1834203002: use std::vector in more places in JavaScript bindings code. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@util_printx
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef FPDFSDK_JAVASCRIPT_JS_RUNTIME_H_ 7 #ifndef FPDFSDK_JAVASCRIPT_JS_RUNTIME_H_
8 #define FPDFSDK_JAVASCRIPT_JS_RUNTIME_H_ 8 #define FPDFSDK_JAVASCRIPT_JS_RUNTIME_H_
9 9
10 #include <map> 10 #include <map>
11 #include <set> 11 #include <set>
12 #include <utility> 12 #include <utility>
13 #include <vector> 13 #include <vector>
dsinclair 2016/03/28 18:57:33 nit: #include <memory>
Tom Sepez 2016/03/28 23:47:18 Done.
14 14
15 #include "core/fxcrt/include/fx_basic.h" 15 #include "core/fxcrt/include/fx_basic.h"
16 #include "fpdfsdk/include/javascript/IJavaScript.h" 16 #include "fpdfsdk/include/javascript/IJavaScript.h"
17 #include "fpdfsdk/include/jsapi/fxjs_v8.h" 17 #include "fpdfsdk/include/jsapi/fxjs_v8.h"
18 #include "fpdfsdk/javascript/JS_EventHandler.h" 18 #include "fpdfsdk/javascript/JS_EventHandler.h"
19 19
20 class CJS_Context; 20 class CJS_Context;
21 21
22 class CJS_Runtime : public IJS_Runtime { 22 class CJS_Runtime : public IJS_Runtime {
23 public: 23 public:
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 FX_BOOL SetHValueByName(const CFX_ByteStringC& utf8Name, 68 FX_BOOL SetHValueByName(const CFX_ByteStringC& utf8Name,
69 FXJSE_HVALUE hValue) override; 69 FXJSE_HVALUE hValue) override;
70 #endif // PDF_ENABLE_XFA 70 #endif // PDF_ENABLE_XFA
71 71
72 void AddObserver(Observer* observer); 72 void AddObserver(Observer* observer);
73 void RemoveObserver(Observer* observer); 73 void RemoveObserver(Observer* observer);
74 74
75 private: 75 private:
76 void DefineJSObjects(); 76 void DefineJSObjects();
77 77
78 CFX_ArrayTemplate<CJS_Context*> m_ContextArray; 78 std::vector<std::unique_ptr<CJS_Context>> m_ContextArray;
79 CPDFDoc_Environment* m_pApp; 79 CPDFDoc_Environment* const m_pApp;
80 CPDFSDK_Document* m_pDocument; 80 CPDFSDK_Document* m_pDocument;
81 FX_BOOL m_bBlocking; 81 FX_BOOL m_bBlocking;
82 std::set<FieldEvent> m_FieldEventSet; 82 std::set<FieldEvent> m_FieldEventSet;
83 v8::Isolate* m_isolate; 83 v8::Isolate* m_isolate;
84 bool m_isolateManaged; 84 bool m_isolateManaged;
85 v8::Global<v8::Context> m_context; 85 v8::Global<v8::Context> m_context;
86 std::vector<v8::Global<v8::Object>*> m_StaticObjects; 86 std::vector<v8::Global<v8::Object>*> m_StaticObjects;
87 std::map<CFX_WideString, v8::Global<v8::Array>> m_ConstArrays; 87 std::map<CFX_WideString, v8::Global<v8::Array>> m_ConstArrays;
88 std::set<Observer*> m_observers; 88 std::set<Observer*> m_observers;
89 }; 89 };
90 90
91 #endif // FPDFSDK_JAVASCRIPT_JS_RUNTIME_H_ 91 #endif // FPDFSDK_JAVASCRIPT_JS_RUNTIME_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698