Followup to 'Scripts to upload and update the mac toolchain.'

Followup to 'Scripts to upload and update the mac toolchain.'

Incorrectly reverted this file before landing.  Make sure DEVELOPER_DIR
is set before calling in to GYP.

Original CL here: https://codereview.chromium.org/1759793003/

BUG=474373
TBR=thakis@chromium.org

Committed: https://crrev.com/e0f8ddf1385487970fb0b6f7677efa54d349d8bf
Cr-Commit-Position: refs/heads/master@{#383497}

[justincohen, 2016-03-28 14:56:17]

Description was changed from

==========
Followup to 'Scripts to upload and update the mac toolchain.'

Incorrectly reverted this file before landing.  Make sure DEVELOPER_DIR
is set before calling in to GYP.

Original CL here: https://codereview.chromium.org/1759793003/

BUG=474373
==========

to

==========
Followup to 'Scripts to upload and update the mac toolchain.'

Incorrectly reverted this file before landing.  Make sure DEVELOPER_DIR
is set before calling in to GYP.

Original CL here: https://codereview.chromium.org/1759793003/

BUG=474373
TBR=erikchen@chromium.org
==========

[justincohen, 2016-03-28 14:56:31]

Description was changed from

==========
Followup to 'Scripts to upload and update the mac toolchain.'

Incorrectly reverted this file before landing.  Make sure DEVELOPER_DIR
is set before calling in to GYP.

Original CL here: https://codereview.chromium.org/1759793003/

BUG=474373
TBR=erikchen@chromium.org
==========

to

==========
Followup to 'Scripts to upload and update the mac toolchain.'

Incorrectly reverted this file before landing.  Make sure DEVELOPER_DIR
is set before calling in to GYP.

Original CL here: https://codereview.chromium.org/1759793003/

BUG=474373
TBR=thakis@chromium.org
==========

[justincohen, 2016-03-28 14:57:05]

justincohen@chromium.org changed reviewers:
+ erikchen@chromium.org

[justincohen, 2016-03-28 14:57:06]

Oops, this should have been part of the previous CL, but I reverted too many
files before landing.

PTAL

[erikchen, 2016-03-28 15:00:33]

lgtm

https://codereview.chromium.org/1834183002/diff/1/build/gyp_environment.py
File build/gyp_environment.py (right):

https://codereview.chromium.org/1834183002/diff/1/build/gyp_environment.py#ne...
build/gyp_environment.py:35: mac_toolchain_dir =
mac_toolchain.GetToolchainDirectory()
can you also update GetToolchainDirectory to explicitly "return None" at the end
of the function?

[justincohen, 2016-03-28 15:12:34]

https://codereview.chromium.org/1834183002/diff/1/build/gyp_environment.py
File build/gyp_environment.py (right):

https://codereview.chromium.org/1834183002/diff/1/build/gyp_environment.py#ne...
build/gyp_environment.py:35: mac_toolchain_dir =
mac_toolchain.GetToolchainDirectory()
On 2016/03/28 15:00:33, erikchen wrote:
> can you also update GetToolchainDirectory to explicitly "return None" at the
end
> of the function?

Done.

[justincohen, 2016-03-28 15:12:45]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-03-28 15:12:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1834183002/#ps20001
(title: "Erik comments")

[commit-bot: I haz the power, 2016-03-28 15:12:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834183002/20001

[commit-bot: I haz the power, 2016-03-28 15:48:16]

Description was changed from

==========
Followup to 'Scripts to upload and update the mac toolchain.'

Incorrectly reverted this file before landing.  Make sure DEVELOPER_DIR
is set before calling in to GYP.

Original CL here: https://codereview.chromium.org/1759793003/

BUG=474373
TBR=thakis@chromium.org
==========

to

==========
Followup to 'Scripts to upload and update the mac toolchain.'

Incorrectly reverted this file before landing.  Make sure DEVELOPER_DIR
is set before calling in to GYP.

Original CL here: https://codereview.chromium.org/1759793003/

BUG=474373
TBR=thakis@chromium.org
==========

[commit-bot: I haz the power, 2016-03-28 15:48:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-28 15:49:31]

Description was changed from

==========
Followup to 'Scripts to upload and update the mac toolchain.'

Incorrectly reverted this file before landing.  Make sure DEVELOPER_DIR
is set before calling in to GYP.

Original CL here: https://codereview.chromium.org/1759793003/

BUG=474373
TBR=thakis@chromium.org
==========

to

==========
Followup to 'Scripts to upload and update the mac toolchain.'

Incorrectly reverted this file before landing.  Make sure DEVELOPER_DIR
is set before calling in to GYP.

Original CL here: https://codereview.chromium.org/1759793003/

BUG=474373
TBR=thakis@chromium.org

Committed: https://crrev.com/e0f8ddf1385487970fb0b6f7677efa54d349d8bf
Cr-Commit-Position: refs/heads/master@{#383497}
==========

[commit-bot: I haz the power, 2016-03-28 15:49:32]

Patchset 2 (id:??) landed as
https://crrev.com/e0f8ddf1385487970fb0b6f7677efa54d349d8bf
Cr-Commit-Position: refs/heads/master@{#383497}