git cl status for Gerrit.

git cl status for Gerrit.

R=ukai@chromium.org
BUG=579172
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299532

[tandrii(chromium), 2016-03-28 01:25:10]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 01:25:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834133002/1

[commit-bot: I haz the power, 2016-03-28 01:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 01:27:47]

Dry run: This issue passed the CQ dry run.

[ukai, 2016-03-28 02:19:51]

https://codereview.chromium.org/1834133002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1834133002/diff/1/git_cl.py#newcode1606
git_cl.py:1606: return 'abandoned'
'closed' ?
(or add 'abondoned' in docstring above?)

https://codereview.chromium.org/1834133002/diff/1/git_cl.py#newcode1613
git_cl.py:1613: if vote_text.lower() == 'Commit'.lower():
if vote.text.lower() == 'commit':
?

https://codereview.chromium.org/1834133002/diff/1/git_cl.py#newcode1619
git_cl.py:1619: return 'not lgtm'
'waiting' ?
(or add 'not lgtm' in docstring above?)

[tandrii(chromium), 2016-03-28 18:57:22]

thanks for review. PTAL

https://codereview.chromium.org/1834133002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1834133002/diff/1/git_cl.py#newcode1606
git_cl.py:1606: return 'abandoned'
On 2016/03/28 02:19:51, ukai wrote:
> 'closed' ?
> (or add 'abondoned' in docstring above?)

Done.

https://codereview.chromium.org/1834133002/diff/1/git_cl.py#newcode1613
git_cl.py:1613: if vote_text.lower() == 'Commit'.lower():
On 2016/03/28 02:19:51, ukai wrote:
> if vote.text.lower() == 'commit':
> ?

Done.

https://codereview.chromium.org/1834133002/diff/1/git_cl.py#newcode1619
git_cl.py:1619: return 'not lgtm'
On 2016/03/28 02:19:51, ukai wrote:
> 'waiting' ?
> (or add 'not lgtm' in docstring above?)

Done.

[ukai, 2016-03-29 02:04:47]

lgtm

[tandrii(chromium), 2016-03-29 09:50:13]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-03-29 09:50:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834133002/20001

[commit-bot: I haz the power, 2016-03-29 09:52:34]

Description was changed from

==========
git cl status for Gerrit.

R=ukai@chromium.org
BUG=579172
==========

to

==========
git cl status for Gerrit.

R=ukai@chromium.org
BUG=579172

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299532
==========

[commit-bot: I haz the power, 2016-03-29 09:52:35]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299532