Add types.private.ChromeDirectSetting and Connect it to preferencesPrivate.googleGeolocationAccessE…

chrome/browser/extensions/api/preference/chrome_direct_setting.cc

Index: chrome/browser/extensions/api/preference/chrome_direct_setting.cc
diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting.cc b/chrome/browser/extensions/api/preference/chrome_direct_setting.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5af73fd10d6cc33c404f22811468469f0b78dca2
--- /dev/null
+++ b/chrome/browser/extensions/api/preference/chrome_direct_setting.cc
@@ -0,0 +1,95 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/preference/chrome_direct_setting.h"
+
+#include "base/prefs/pref_service.h"
+#include "base/values.h"
+#include "chrome/browser/extensions/api/preference/preference_api_constants.h"
+#include "chrome/browser/profiles/profile.h"
+
+namespace extensions {
+namespace chromedirectsetting {
+
+bool DirectSettingFunctionBase::IsCalledFromComponentExtension() {
+  return GetExtension()->location() == Manifest::COMPONENT;
+}
+
+bool DirectSettingFunctionBase::IsPreferenceOnWhitelist(
+    const std::string &pref_key) {

[Bernhard Bauer, 2013/07/09 22:27:22]

Nit: the ampersand comes after the type, not before the variable.

[robliao, 2013/07/09 23:07:23]

Done.

+  return preference_whitelist_.find(pref_key) != preference_whitelist_.end();
+}
+
+PreferenceWhitelist DirectSettingFunctionBase::CreatePreferenceWhitelist() {
+  base::hash_set<std::string> whitelist;
+  whitelist.insert("googlegeolocationaccess.enabled");
+  return whitelist;
+}
+
+const PreferenceWhitelist DirectSettingFunctionBase::preference_whitelist_ =

[Bernhard Bauer, 2013/07/09 22:27:22]

This creates a static initializer, which isn't allowed in Chrome code.

Common alternatives are using a LazyInstance, a custom Singleton class, or a
plain old data list of const char[] that you iterate over.

[robliao, 2013/07/09 23:07:23]

I was afraid of that. Changed to use LazyInstance.
On 2013/07/09 22:27:22, Bernhard Bauer wrote:

+    DirectSettingFunctionBase::CreatePreferenceWhitelist();
+
+PrefService* DirectSettingFunctionBase::GetPrefService() {
+  return profile()->GetPrefs();
+}
+
+bool GetDirectSettingFunction::RunImpl() {
+  EXTENSION_FUNCTION_VALIDATE(IsCalledFromComponentExtension());
+
+  std::string pref_key;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &pref_key));
+  EXTENSION_FUNCTION_VALIDATE(IsPreferenceOnWhitelist(pref_key));
+
+  const PrefService::Preference* preference =
+      GetPrefService()->FindPreference(pref_key.c_str());
+  EXTENSION_FUNCTION_VALIDATE(preference);
+  const base::Value* value = preference->GetValue();
+
+  scoped_ptr<DictionaryValue> result(new DictionaryValue);
+  result->Set(preference_api_constants::kValue, value->DeepCopy());
+  SetResult(result.release());
+
+  return true;
+}
+
+bool SetDirectSettingFunction::RunImpl() {
+  EXTENSION_FUNCTION_VALIDATE(IsCalledFromComponentExtension());
+
+  std::string pref_key;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &pref_key));
+  EXTENSION_FUNCTION_VALIDATE(IsPreferenceOnWhitelist(pref_key));
+
+  DictionaryValue* details = NULL;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(1, &details));
+
+  Value* value = NULL;
+  EXTENSION_FUNCTION_VALIDATE(
+      details->Get(preference_api_constants::kValue, &value));
+
+  PrefService* pref_service = GetPrefService();
+  const PrefService::Preference* preference =
+      pref_service->FindPreference(pref_key.c_str());
+  EXTENSION_FUNCTION_VALIDATE(preference);
+
+  EXTENSION_FUNCTION_VALIDATE(value->GetType() == preference->GetType());
+
+  pref_service->Set(pref_key.c_str(), *value);
+
+  return true;
+}
+
+bool ClearDirectSettingFunction::RunImpl() {
+  EXTENSION_FUNCTION_VALIDATE(IsCalledFromComponentExtension());
+
+  std::string pref_key;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &pref_key));
+  EXTENSION_FUNCTION_VALIDATE(IsPreferenceOnWhitelist(pref_key));
+  GetPrefService()->ClearPref(pref_key.c_str());
+
+  return true;
+}
+
+}  // namespace chromedirectsetting
+}  // namespace extensions
+