Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7391)

Unified Diff: chrome/renderer/resources/extensions/chrome_direct_setting.js

Issue 18341016: Add types.private.ChromeDirectSetting and Connect it to preferencesPrivate.googleGeolocationAccessE… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/chrome_direct_setting.js
diff --git a/chrome/renderer/resources/extensions/chrome_setting.js b/chrome/renderer/resources/extensions/chrome_direct_setting.js
similarity index 71%
copy from chrome/renderer/resources/extensions/chrome_setting.js
copy to chrome/renderer/resources/extensions/chrome_direct_setting.js
index 8d6f29e3fd2911d06bdd374ee2a6f976dc2870b1..e5b2d9ec375e4f4919082f474be6cba7e3c27395 100644
--- a/chrome/renderer/resources/extensions/chrome_setting.js
+++ b/chrome/renderer/resources/extensions/chrome_direct_setting.js
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -12,11 +12,11 @@ function extendSchema(schema) {
return extendedSchema;
}
-function ChromeSetting(prefKey, valueSchema) {
+function ChromeDirectSetting(prefKey, valueSchema) {
this.get = function(details, callback) {
var getSchema = this.functionSchemas.get.definition.parameters;
validate([details, callback], getSchema);
- return sendRequest('types.ChromeSetting.get',
+ return sendRequest('types.private.ChromeDirectSetting.get',
[prefKey, details, callback],
extendSchema(getSchema));
};
@@ -25,18 +25,21 @@ function ChromeSetting(prefKey, valueSchema) {
this.functionSchemas.set.definition.parameters);
setSchema[0].properties.value = valueSchema;
validate([details, callback], setSchema);
- return sendRequest('types.ChromeSetting.set',
+ return sendRequest('types.private.ChromeDirectSetting.set',
[prefKey, details, callback],
extendSchema(setSchema));
};
this.clear = function(details, callback) {
var clearSchema = this.functionSchemas.clear.definition.parameters;
validate([details, callback], clearSchema);
- return sendRequest('types.ChromeSetting.clear',
+ return sendRequest('types.private.ChromeDirectSetting.clear',
[prefKey, details, callback],
extendSchema(clearSchema));
};
- this.onChange = new Event('types.ChromeSetting.' + prefKey + '.onChange');
+ this.onChange = new Event('types.private.ChromeDirectSetting.' +
+ prefKey +
+ '.onChange');
};
-exports.ChromeSetting = ChromeSetting;
+exports.ChromeDirectSetting = ChromeDirectSetting;
+

Powered by Google App Engine
This is Rietveld 408576698