Add types.private.ChromeDirectSetting and Connect it to preferencesPrivate.googleGeolocationAccessE…

chrome/browser/extensions/api/preference/chrome_direct_setting.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_PREFERENCE_CHROME_DIRECT_SETTING_H__
+#define CHROME_BROWSER_EXTENSIONS_API_PREFERENCE_CHROME_DIRECT_SETTING_H__
+
+#include "base/lazy_instance.h"
+#include "chrome/browser/extensions/extension_function.h"
+
+class PrefService;
+
+namespace extensions {
+namespace chromedirectsetting {
+
+// Base class to host instance method helpers.
+class DirectSettingFunctionBase : public SyncExtensionFunction {
+ protected:
+  explicit DirectSettingFunctionBase() {}
+  virtual ~DirectSettingFunctionBase() {}
+
+  // Returns the user pref service.
+  PrefService* GetPrefService();
+
+  // Returns true if the caller is a component extension.
+  bool IsCalledFromComponentExtension();
+
+  // Returns true if the preference is on the whitelist.
+  bool IsPreferenceOnWhitelist(const std::string& pref_key);
+
+ private:
+  class PreferenceWhitelist {

[Bernhard Bauer, 2013/07/09 23:23:44]

You can move this class (and the variable) to the implementation file, in an
anomymous namespace.

[robliao, 2013/07/09 23:37:41]

I'll move the class, but keep it in the namespace.

I've found dealing with anonymous namespaces a nightmare in cdb/ntsd/windbg. You
can't identify them since they are... anonymous!

On 2013/07/09 23:23:44, Bernhard Bauer wrote:

[Bernhard Bauer, 2013/07/10 10:52:25]

I'm sorry, but that's not the customary way in Chromium code: see
http://dev.chromium.org/developers/coding-style#TOC-Unnamed-Namespaces. If we
really need to reference an internal class somewhere else, we usually put it
into an ...::internal namespace, but ease of debugging alone doesn't justify it.

[robliao, 2013/07/10 16:52:39]

Where can I provide feedback on this rule? I've burned through a lot of time
just waiting on anonymous namespaces to resolve in the debugger.

In the meantime, I've wrapped the object.
On 2013/07/10 10:52:25, Bernhard Bauer wrote:

+   public:
+    explicit PreferenceWhitelist();

[Bernhard Bauer, 2013/07/09 23:23:44]

Explicit is only necessary for single-argument constructors.

[robliao, 2013/07/09 23:37:41]

Done.

+
+    bool IsPreferenceOnWhitelist(const std::string& pref_key);
+
+   private:
+    base::hash_set<std::string> whitelist_;
+
+    DISALLOW_COPY_AND_ASSIGN(PreferenceWhitelist);
+  };
+
+  static base::LazyInstance<PreferenceWhitelist> preference_whitelist_;
+  DISALLOW_COPY_AND_ASSIGN(DirectSettingFunctionBase);
+};
+
+class GetDirectSettingFunction : public DirectSettingFunctionBase {
+ public:
+  DECLARE_EXTENSION_FUNCTION("types.private.ChromeDirectSetting.get",
+                             TYPES_PRIVATE_CHROMEDIRECTSETTING_GET)
+
+  explicit GetDirectSettingFunction() {}
+
+ protected:
+  // ExtensionFunction:
+  virtual bool RunImpl() OVERRIDE;
+
+ private:
+  virtual ~GetDirectSettingFunction() {}
+  DISALLOW_COPY_AND_ASSIGN(GetDirectSettingFunction);
+};
+
+class SetDirectSettingFunction : public DirectSettingFunctionBase {
+ public:
+  DECLARE_EXTENSION_FUNCTION("types.private.ChromeDirectSetting.set",
+                             TYPES_PRIVATE_CHROMEDIRECTSETTING_SET)
+
+  explicit SetDirectSettingFunction() {}
+
+ protected:
+  // ExtensionFunction:
+  virtual bool RunImpl() OVERRIDE;
+
+ private:
+  virtual ~SetDirectSettingFunction() {}
+  DISALLOW_COPY_AND_ASSIGN(SetDirectSettingFunction);
+};
+
+class ClearDirectSettingFunction : public DirectSettingFunctionBase {
+ public:
+  DECLARE_EXTENSION_FUNCTION("types.private.ChromeDirectSetting.clear",
+                             TYPES_PRIVATE_CHROMEDIRECTSETTING_CLEAR)
+
+  explicit ClearDirectSettingFunction() {}
+
+ protected:
+  // ExtensionFunction:
+  virtual bool RunImpl() OVERRIDE;
+
+ private:
+  virtual ~ClearDirectSettingFunction() {}
+  DISALLOW_COPY_AND_ASSIGN(ClearDirectSettingFunction);
+};
+
+}  // namespace chromedirectsetting
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_PREFERENCE_CHROME_DIRECT_SETTING_H__
+